Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1999910FC9 for ; Fri, 30 May 2014 02:58:31 +0000 (UTC) Received: (qmail 65503 invoked by uid 500); 30 May 2014 02:58:31 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 65461 invoked by uid 500); 30 May 2014 02:58:31 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 65453 invoked by uid 99); 30 May 2014 02:58:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 May 2014 02:58:30 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 30 May 2014 02:58:31 +0000 Received: (qmail 65404 invoked by uid 99); 30 May 2014 02:58:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 May 2014 02:58:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 43BF81D9868; Fri, 30 May 2014 02:57:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0757248214566679340==" MIME-Version: 1.0 Subject: Re: Review Request 22065: Fix /cron endpoint. From: "Bill Farner" To: "Bill Farner" , "David McLaughlin" Cc: "Aurora" , "Kevin Sweeney" Date: Fri, 30 May 2014 02:57:58 -0000 Message-ID: <20140530025758.12584.34989@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/22065/ X-Sender: "Bill Farner" References: <20140530013235.12584.72452@reviews.apache.org> In-Reply-To: <20140530013235.12584.72452@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0757248214566679340== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22065/#review44326 ----------------------------------------------------------- Ship it! Ship It! - Bill Farner On May 30, 2014, 1:32 a.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22065/ > ----------------------------------------------------------- > > (Updated May 30, 2014, 1:32 a.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-478 > https://issues.apache.org/jira/browse/AURORA-478 > > > Repository: aurora > > > Description > ------- > > Fix /cron endpoint. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 3359425b5f19e68f33c46c5191ad100c1857d978 > src/main/java/org/apache/aurora/scheduler/http/Cron.java 6ccf5833012b4282e6a0fc94db39ac4ccd5ce77f > src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java efa0a583dfa63ae1240a2fff128d97497c83536e > src/test/java/org/apache/aurora/scheduler/http/CronTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/22065/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > ./gradlew run > curl -s http://localhost:8081/cron | python -m json.tool > > > Thanks, > > Kevin Sweeney > > --===============0757248214566679340==--