Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7742E10DCB for ; Fri, 30 May 2014 01:20:37 +0000 (UTC) Received: (qmail 66284 invoked by uid 500); 30 May 2014 01:20:37 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 66244 invoked by uid 500); 30 May 2014 01:20:37 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 66236 invoked by uid 99); 30 May 2014 01:20:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 May 2014 01:20:37 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 30 May 2014 01:20:37 +0000 Received: (qmail 65091 invoked by uid 99); 30 May 2014 01:20:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 May 2014 01:20:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AA1E11D993E; Fri, 30 May 2014 01:20:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2043028585173443973==" MIME-Version: 1.0 Subject: Re: Review Request 22065: Fix /cron endpoint. From: "Kevin Sweeney" To: "Bill Farner" , "David McLaughlin" Cc: "Aurora" , "Kevin Sweeney" Date: Fri, 30 May 2014 01:20:04 -0000 Message-ID: <20140530012004.12585.95206@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/22065/ X-Sender: "Kevin Sweeney" References: <20140530010933.12585.2782@reviews.apache.org> In-Reply-To: <20140530010933.12585.2782@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============2043028585173443973== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22065/ ----------------------------------------------------------- (Updated May 29, 2014, 6:20 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Changes ------- Add test coverage that passes checkstyle. Bugs: AURORA-478 https://issues.apache.org/jira/browse/AURORA-478 Repository: aurora Description ------- Fix /cron endpoint. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 3359425b5f19e68f33c46c5191ad100c1857d978 src/main/java/org/apache/aurora/scheduler/http/Cron.java 6ccf5833012b4282e6a0fc94db39ac4ccd5ce77f src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java efa0a583dfa63ae1240a2fff128d97497c83536e src/test/java/org/apache/aurora/scheduler/http/CronTest.java PRE-CREATION Diff: https://reviews.apache.org/r/22065/diff/ Testing ------- ./gradlew -Pq build ./gradlew run curl -s http://localhost:8081/cron | python -m json.tool Thanks, Kevin Sweeney --===============2043028585173443973==--