Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 56A1811698 for ; Fri, 23 May 2014 21:17:43 +0000 (UTC) Received: (qmail 32363 invoked by uid 500); 23 May 2014 21:17:43 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 32324 invoked by uid 500); 23 May 2014 21:17:43 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 32316 invoked by uid 99); 23 May 2014 21:17:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 May 2014 21:17:43 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 23 May 2014 21:17:41 +0000 Received: (qmail 29595 invoked by uid 99); 23 May 2014 21:17:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 May 2014 21:17:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 06D731D9688; Fri, 23 May 2014 21:17:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8340491875450709336==" MIME-Version: 1.0 Subject: Re: Review Request 21825: Added tabs for active and completed tasks in Job page. From: "Suman Karumuri" To: "Bill Farner" , "David McLaughlin" Cc: "Aurora" , "Suman Karumuri" Date: Fri, 23 May 2014 21:17:14 -0000 Message-ID: <20140523211714.8064.96236@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Suman Karumuri" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/21825/ X-Sender: "Suman Karumuri" References: <20140523211605.29111.46349@reviews.apache.org> In-Reply-To: <20140523211605.29111.46349@reviews.apache.org> Reply-To: "Suman Karumuri" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8340491875450709336== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21825/ ----------------------------------------------------------- (Updated May 23, 2014, 9:17 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-425 https://issues.apache.org/jira/browse/AURORA-425 Repository: aurora Description ------- Moved task tables into active and completed tabs on job page. Installed angular-ui/bootstrap project since we need the tabset directive from it. Upgraded angular js to version 1.2.9 from 1.2.6. Diffs ----- 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json PRE-CREATION 3rdparty/javascript/bower_components/angular-bootstrap/bower.json PRE-CREATION 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js PRE-CREATION 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js PRE-CREATION 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js PRE-CREATION 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js PRE-CREATION 3rdparty/javascript/bower_components/angular/.bower.json ee8284d59e3d13b2c9ea444caebf4b3d07323460 3rdparty/javascript/bower_components/angular/angular.js d4d7abc0b72626c0c7028c8ac013f4218df71d07 3rdparty/javascript/bower_components/angular/angular.min.js d3daf08b075b48d53860fd1c119ff736efa9f6c4 3rdparty/javascript/bower_components/angular/angular.min.js.gzip 879a6b82f0f72cc79b06918150327fd025474adb 3rdparty/javascript/bower_components/angular/angular.min.js.map 68739de57996eac63fbf4da9fd45fc93d80c899c 3rdparty/javascript/bower_components/angular/bower.json 9079df91659e6965eeff30ae68e0c22211e2ab14 src/main/java/org/apache/aurora/scheduler/http/ServletModule.java f7da8c669cb02c2330dc106a5bf628f308200a59 src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css c9a95ad3b3dcd53a68f1a6cb0fd22507af119b60 src/main/resources/org/apache/aurora/scheduler/http/ui/index.html c805a171a7caf87b0357d6c6ce336b25f884895b src/main/resources/org/apache/aurora/scheduler/http/ui/job.html 8437d3008d310261ec0b02e62dd13c64ee5dcc4f src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js aca1e396ec3653cbc2277cbf54ad1250f286b9f9 src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 87cdfb243a672e768839d5f84fc934d077994039 Diff: https://reviews.apache.org/r/21825/diff/ Testing ------- ./gradlew run && ./gradlew build File Attachments (updated) ---------------- active tasks tab https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png completed tasks tab https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png all tasks tab https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png Tabs with task counts https://reviews.apache.org/media/uploaded/files/2014/05/23/c5a6a3c6-bef0-4726-ae2f-83bf8a575e61__Screen_Shot_2014-05-23_at_2.16.36_PM.png Thanks, Suman Karumuri --===============8340491875450709336==--