Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 92AD611216 for ; Thu, 22 May 2014 18:06:49 +0000 (UTC) Received: (qmail 96456 invoked by uid 500); 22 May 2014 18:06:49 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 96415 invoked by uid 500); 22 May 2014 18:06:49 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 96407 invoked by uid 99); 22 May 2014 18:06:49 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 May 2014 18:06:49 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 22 May 2014 18:06:48 +0000 Received: (qmail 95275 invoked by uid 99); 22 May 2014 18:06:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 May 2014 18:06:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 442641D948D; Thu, 22 May 2014 18:06:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6895368396570142292==" MIME-Version: 1.0 Subject: Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only) From: "Henry Saputra" To: "Maxim Khutornenko" , "Kevin Sweeney" Cc: "Aurora" , "David McLaughlin" , "Henry Saputra" Date: Thu, 22 May 2014 18:06:20 -0000 Message-ID: <20140522180620.29111.78568@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Henry Saputra" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/21132/ X-Sender: "Henry Saputra" References: <20140522180057.29111.18731@reviews.apache.org> In-Reply-To: <20140522180057.29111.18731@reviews.apache.org> Reply-To: "Henry Saputra" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6895368396570142292== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/#review43743 ----------------------------------------------------------- Could you describe a bit details on what changes submitted with the patch? Maybe it makes sense to internal folks at Twitter but not useful for new/ external people - Henry Saputra On May 22, 2014, 6 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21132/ > ----------------------------------------------------------- > > (Updated May 22, 2014, 6 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-335 > https://issues.apache.org/jira/browse/AURORA-335 > > > Repository: aurora > > > Description > ------- > > Initial attempt at h2/DB storage implementation (LockStore only) > > > Diffs > ----- > > build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 > src/main/java/org/apache/aurora/scheduler/base/JobKeys.java db1bec4f508c8908f212aa541fb86e041a8c471c > src/main/java/org/apache/aurora/scheduler/storage/Storage.java 4b33fe5dd8223ff04060de0fe16b1c0759ead956 > src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/db/JobKeyMapper.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/db/LockKeyMapper.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/db/LockMapper.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/db/views/LockRow.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java c851eeb412b17097ff42abce2b7a42fc1c249013 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 4d43f47de75a8bef06f106f563cc071df4cdf093 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemLockStore.java a6319f65bff07db66197e6476647117df6be5c9d > src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 283976ab0554dbe6700bb0d2a1b7702c969227e8 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 53923627c827131ee4bd93e5c4865d042aee501b > src/main/resources/org/apache/aurora/scheduler/storage/db/JobKeyMapper.xml PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/storage/db/LockMapper.xml PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql PRE-CREATION > src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 34377430268002e8e8e5bc803b409e092bb86720 > src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java a5191500b2958253e14843089a15a1ffd58e6846 > > Diff: https://reviews.apache.org/r/21132/diff/ > > > Testing > ------- > > > Thanks, > > David McLaughlin > > --===============6895368396570142292==--