Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 317AD11569 for ; Tue, 20 May 2014 21:04:26 +0000 (UTC) Received: (qmail 53793 invoked by uid 500); 20 May 2014 21:04:26 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 53758 invoked by uid 500); 20 May 2014 21:04:26 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 53749 invoked by uid 99); 20 May 2014 21:04:26 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 May 2014 21:04:26 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 20 May 2014 21:04:24 +0000 Received: (qmail 52464 invoked by uid 99); 20 May 2014 21:04:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 May 2014 21:04:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 007931D9146; Tue, 20 May 2014 21:03:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7209496815433856387==" MIME-Version: 1.0 Subject: Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API. From: "David McLaughlin" To: "Bill Farner" , "David McLaughlin" Cc: "Aurora" , "Mark Chu-Carroll" Date: Tue, 20 May 2014 21:03:56 -0000 Message-ID: <20140520210356.21125.14608@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "David McLaughlin" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/21383/ X-Sender: "David McLaughlin" References: <20140520002528.20172.1110@reviews.apache.org> In-Reply-To: <20140520002528.20172.1110@reviews.apache.org> Reply-To: "David McLaughlin" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7209496815433856387== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/#review43535 ----------------------------------------------------------- Ship it! lgtm. - David McLaughlin On May 20, 2014, 12:25 a.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21383/ > ----------------------------------------------------------- > > (Updated May 20, 2014, 12:25 a.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: aurora-417 > https://issues.apache.org/jira/browse/aurora-417 > > > Repository: aurora > > > Description > ------- > > Add cron schedule and deschedule calls to the scheduler API. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 4386a86c0aebdb9666c0232672f8c1bab7458f47 > src/main/thrift/org/apache/aurora/gen/api.thrift 66292dc0369941fc62719d49209edc07adc81a53 > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2142f116afffdbd9acb63b835c240f03f417c511 > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 933a56bf3f7165fa84aedcc8d1392e32824fd487 > src/test/python/apache/aurora/client/api/test_scheduler_client.py 399d4c614dda93ae0e7d8f38a02379bc0f42e4af > > Diff: https://reviews.apache.org/r/21383/diff/ > > > Testing > ------- > > Ran all tests with gradlew; no errors. (Includes two new tests, that ensure that calling the new APIs causes the right internal cron methods to be called.) > > > Thanks, > > Mark Chu-Carroll > > --===============7209496815433856387==--