Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 047D611BD0 for ; Tue, 13 May 2014 01:17:40 +0000 (UTC) Received: (qmail 13613 invoked by uid 500); 13 May 2014 01:11:00 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 13473 invoked by uid 500); 13 May 2014 01:11:00 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 13341 invoked by uid 99); 13 May 2014 01:11:00 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 May 2014 01:11:00 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 13 May 2014 01:10:59 +0000 Received: (qmail 85780 invoked by uid 99); 12 May 2014 22:23:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 May 2014 22:23:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 26C381D76B0; Mon, 12 May 2014 22:23:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0790514545438753866==" MIME-Version: 1.0 Subject: Re: Review Request 21247: Add config grouping visualisation to job page From: "Suman Karumuri" To: "Bill Farner" , "Suman Karumuri" Cc: "Aurora" , "David McLaughlin" Date: Mon, 12 May 2014 22:23:52 -0000 Message-ID: <20140512222352.7395.12489@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Suman Karumuri" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/21247/ X-Sender: "Suman Karumuri" References: <20140512202835.5509.10680@reviews.apache.org> In-Reply-To: <20140512202835.5509.10680@reviews.apache.org> Reply-To: "Suman Karumuri" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0790514545438753866== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21247/#review42759 ----------------------------------------------------------- Also, please think of a way to test this locally. src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js Please delete the code for the task summary table from the controller. - Suman Karumuri On May 12, 2014, 8:28 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21247/ > ----------------------------------------------------------- > > (Updated May 12, 2014, 8:28 p.m.) > > > Review request for Aurora, Suman Karumuri and Bill Farner. > > > Bugs: AURORA-378 > https://issues.apache.org/jira/browse/AURORA-378 > > > Repository: aurora > > > Description > ------- > > Replace the button to show/hide configs with a bar when there are multiple. Tidied up the display of the configuration data. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 983101277ffbd1c4017b29f4c86e61315f1bcc78 > src/main/resources/org/apache/aurora/scheduler/http/ui/configSummary.html PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css dc515ac818a9af36522bb07a125cd92ff9230fa2 > src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/http/ui/job.html cd78c20bee7891a6cdfd19943a6f7e8a9dce33df > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7c80bd769b7e80bef0822846166959925b1bf7f8 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js a79276d2486fc1122a8b084ea0614cdae759f88c > > Diff: https://reviews.apache.org/r/21247/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Job page with only one config group > https://reviews.apache.org/media/uploaded/files/2014/05/08/908570f2-bef2-4370-bf08-1b5c7400c3c6__Screen_Shot_2014-05-08_at_4.26.02_PM.png > Showing config for only one config group > https://reviews.apache.org/media/uploaded/files/2014/05/08/1424f2c3-cf66-4ce4-a595-dc3f7647d6d2__Screen_Shot_2014-05-08_at_4.26.12_PM.png > Job page with multiple config groups > https://reviews.apache.org/media/uploaded/files/2014/05/08/bc9c1616-3c71-4bcc-ab40-fefc56d5e19a__Screen_Shot_2014-05-08_at_4.25.21_PM.png > Viewing one of the groups from config bar > https://reviews.apache.org/media/uploaded/files/2014/05/08/6b8e6077-c8c8-48c9-94e9-732e782204b6__Screen_Shot_2014-05-08_at_4.25.36_PM.png > Viewing multiple configs at the same time > https://reviews.apache.org/media/uploaded/files/2014/05/08/b7b2cba1-034b-43e6-9eaa-3ba1a78f87f5__Screen_Shot_2014-05-08_at_4.25.42_PM.png > screenshot of really small group > https://reviews.apache.org/media/uploaded/files/2014/05/12/2d7999ac-ba1f-45b0-bf9e-99f9c7a10009__Screen_Shot_2014-05-12_at_1.27.59_PM.png > > > Thanks, > > David McLaughlin > > --===============0790514545438753866==--