Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1BAB011648 for ; Sun, 11 May 2014 11:31:16 +0000 (UTC) Received: (qmail 42782 invoked by uid 500); 11 May 2014 10:31:16 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 42742 invoked by uid 500); 11 May 2014 10:31:16 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 42734 invoked by uid 99); 11 May 2014 10:31:16 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 May 2014 10:31:16 +0000 X-ASF-Spam-Status: No, hits=-1998.0 required=5.0 tests=ALL_TRUSTED,DATE_IN_PAST_24_48,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Sun, 11 May 2014 10:31:15 +0000 Received: (qmail 13561 invoked by uid 99); 10 May 2014 22:08:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 May 2014 22:08:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DBD391D7B52; Fri, 9 May 2014 17:59:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2508005515726143518==" MIME-Version: 1.0 Subject: Re: Review Request 21144: Always show resource consumption table on Job page. From: "David McLaughlin" To: "Bill Farner" , "David McLaughlin" Cc: "Aurora" , "Suman Karumuri" Date: Fri, 09 May 2014 17:59:21 -0000 Message-ID: <20140509175921.1086.14380@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "David McLaughlin" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/21144/ X-Sender: "David McLaughlin" References: <20140507013946.28778.25472@reviews.apache.org> In-Reply-To: <20140507013946.28778.25472@reviews.apache.org> Reply-To: "David McLaughlin" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============2508005515726143518== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21144/#review42583 ----------------------------------------------------------- Ship it! Ship It! - David McLaughlin On May 7, 2014, 1:39 a.m., Suman Karumuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21144/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 1:39 a.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-386 > https://issues.apache.org/jira/browse/AURORA-386 > > > Repository: aurora > > > Description > ------- > > Always show resource consumption table on job page. > > > Diffs > ----- > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7c80bd769b7e80bef0822846166959925b1bf7f8 > src/main/resources/org/apache/aurora/scheduler/http/ui/role.html ff631c8d2befa03920e3a0c7ca7c52812063cf0a > > Diff: https://reviews.apache.org/r/21144/diff/ > > > Testing > ------- > > Tested on local laptop. Screenshots attached. > > > File Attachments > ---------------- > > Screen Shot 2014-05-06 at 6.38.46 PM.png > https://reviews.apache.org/media/uploaded/files/2014/05/07/bc2d25f8-79ef-4f3e-b44f-81e668bd32b8__Screen_Shot_2014-05-06_at_6.38.46_PM.png > > > Thanks, > > Suman Karumuri > > --===============2508005515726143518==--