Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CDFBE1152C for ; Tue, 6 May 2014 23:10:34 +0000 (UTC) Received: (qmail 75529 invoked by uid 500); 6 May 2014 23:10:33 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 75491 invoked by uid 500); 6 May 2014 23:10:33 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 75483 invoked by uid 99); 6 May 2014 23:10:32 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 May 2014 23:10:32 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 06 May 2014 23:10:32 +0000 Received: (qmail 74846 invoked by uid 99); 6 May 2014 23:10:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 May 2014 23:10:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6EA0F1D7612; Tue, 6 May 2014 23:09:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6149996475603735932==" MIME-Version: 1.0 Subject: Review Request 21136: Add python import order wrapper/commit hook From: "Brian Wickman" To: "Kevin Sweeney" Cc: "Aurora" , "Brian Wickman" Date: Tue, 06 May 2014 23:09:58 -0000 Message-ID: <20140506230958.7613.12594@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brian Wickman" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/21136/ X-Sender: "Brian Wickman" Reply-To: "Brian Wickman" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6149996475603735932== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21136/ ----------------------------------------------------------- Review request for Aurora and Kevin Sweeney. Repository: aurora Description ------- Adds build-support/isort wrapper for isort. Adds build-support/isort-run to run import sort, build-support/isort-check to run import order check. Adds build-support/hooks which contains hooks that people can place into their .git/hooks directory, currently just a pre-commit hook that checks import sort order (which can be overridden with an environment variable.) The ordering it produces is different than the one we currently have but closer to straight PEP8. If it runs, it's about a 500 line diff which I can send later. Diffs ----- build-support/hooks/pre-commit PRE-CREATION build-support/isort PRE-CREATION build-support/isort-check PRE-CREATION build-support/isort-run PRE-CREATION src/.isort.cfg PRE-CREATION Diff: https://reviews.apache.org/r/21136/diff/ Testing ------- Ran the isort and ran tests, everything worked. Thanks, Brian Wickman --===============6149996475603735932==--