Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7DC4111E95 for ; Tue, 6 May 2014 21:32:09 +0000 (UTC) Received: (qmail 8532 invoked by uid 500); 6 May 2014 20:37:06 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 8468 invoked by uid 500); 6 May 2014 20:37:01 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 8407 invoked by uid 99); 6 May 2014 20:36:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 May 2014 20:36:59 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 06 May 2014 20:36:58 +0000 Received: (qmail 77103 invoked by uid 99); 6 May 2014 18:50:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 May 2014 18:50:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C00851D75CA; Tue, 6 May 2014 18:50:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5890952982876780660==" MIME-Version: 1.0 Subject: Re: Review Request 20394: Add return code to task/process pages From: "Brian Wickman" To: "Brian Wickman" Cc: "Aurora" , "David McLaughlin" Date: Tue, 06 May 2014 18:50:38 -0000 Message-ID: <20140506185038.1482.44708@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brian Wickman" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/20394/ X-Sender: "Brian Wickman" References: <20140428224818.30677.37614@reviews.apache.org> In-Reply-To: <20140428224818.30677.37614@reviews.apache.org> Reply-To: "Brian Wickman" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============5890952982876780660== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20394/#review42339 ----------------------------------------------------------- david -- should i submit this? i just realized that you likely don't have commit privileges, so i think this is up to me to submit. - Brian Wickman On April 28, 2014, 10:48 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20394/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 10:48 p.m.) > > > Review request for Aurora and Brian Wickman. > > > Repository: aurora > > > Description > ------- > > Add return code to task/process pages > > > Diffs > ----- > > src/main/python/apache/thermos/observer/http/http_observer.py 118bd2f4889c520683ba04b554d699ecf0bc20ce > src/main/python/apache/thermos/observer/http/templates/process.tpl a7fb90d4decec01cb95f9e5d42288eaae9d71edf > src/main/python/apache/thermos/observer/http/templates/task.tpl b71c80d11255c111873a46b99478c36d39cc8733 > src/main/python/apache/thermos/observer/task_observer.py ea40bfa610e2af90904487c809bc83b8b5f214d9 > > Diff: https://reviews.apache.org/r/20394/diff/ > > > Testing > ------- > > > Thanks, > > David McLaughlin > > --===============5890952982876780660==--