Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3330C111CE for ; Thu, 1 May 2014 21:40:23 +0000 (UTC) Received: (qmail 80965 invoked by uid 500); 1 May 2014 21:40:20 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 80917 invoked by uid 500); 1 May 2014 21:40:19 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 80890 invoked by uid 99); 1 May 2014 21:40:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 May 2014 21:40:18 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 01 May 2014 21:40:16 +0000 Received: (qmail 80357 invoked by uid 99); 1 May 2014 21:39:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 May 2014 21:39:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B1FD01D7341; Thu, 1 May 2014 21:39:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6331514965856620723==" MIME-Version: 1.0 Subject: Re: Review Request 20928: Command hooks: stage 2. From: "Mark Chu-Carroll" To: "Suman Karumuri" , "David McLaughlin" Cc: "Aurora" , "Mark Chu-Carroll" Date: Thu, 01 May 2014 21:39:49 -0000 Message-ID: <20140501213949.16690.50160@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mark Chu-Carroll" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/20928/ X-Sender: "Mark Chu-Carroll" References: <20140501204710.16690.76916@reviews.apache.org> In-Reply-To: <20140501204710.16690.76916@reviews.apache.org> Reply-To: "Mark Chu-Carroll" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6331514965856620723== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20928/ ----------------------------------------------------------- (Updated May 1, 2014, 5:39 p.m.) Review request for Aurora, David McLaughlin and Suman Karumuri. Changes ------- Address review: - Fix docs. - Simplify the hook-skip check. Bugs: aurora-270 https://issues.apache.org/jira/browse/aurora-270 Repository: aurora Description ------- The second half of command hooks: - Dynamically registered hook exceptions are provided, by fetching a hooks skip rules file from a URL. - Hooks are loaded and activated by the noun/verb framework. - Hook selection and dispatch has been substantially updated. Also did some long overdue cleanup of string quoting consistency. Diffs (updated) ----- 3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 docs/design/command-hooks.md ee320ed3922928408d23a2dfdf3c42ef96e62ff7 src/main/python/apache/aurora/client/cli/BUILD 1bd565effb3dbe2aeb5d6156575e9316bd77c6a8 src/main/python/apache/aurora/client/cli/__init__.py 1e396b2263451b41cd223708f4cc4cdb1eeddbf0 src/main/python/apache/aurora/client/cli/command_hooks.py 2d200682209e1df83c03f9d515f3b118aaa85a99 src/test/python/apache/aurora/client/cli/test_command_hooks.py 7c6f70c7ef7534e9dd4986364331c67f6f7c36b1 Diff: https://reviews.apache.org/r/20928/diff/ Testing ------- [sun-wukong incubator-aurora (command-hooks-two)]$ !./p ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) ============================= test session starts ============================== platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py .... =========================== 4 passed in 0.02 seconds =========================== ============================= test session starts ============================== platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 9 items src/test/python/apache/aurora/client/cli/test_command_hooks.py ......... =========================== 9 passed in 0.80 seconds =========================== ============================= test session starts ============================== platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 5 items src/test/python/apache/aurora/client/cli/test_help.py ..... =========================== 5 passed in 0.70 seconds =========================== ============================= test session starts ============================== platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 36 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py .... src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py ......... src/test/python/apache/aurora/client/cli/test_open.py ..... src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py ....... src/test/python/apache/aurora/client/cli/test_update.py ... ========================== 36 passed in 2.02 seconds =========================== ============================= test session starts ============================== platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 1 items src/test/python/apache/aurora/client/cli/test_logging.py . =========================== 1 passed in 0.65 seconds =========================== ============================= test session starts ============================== platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 3 items src/test/python/apache/aurora/client/cli/test_plugins.py ... =========================== 3 passed in 0.67 seconds =========================== ============================= test session starts ============================== platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 4 items src/test/python/apache/aurora/client/cli/test_quota.py .... =========================== 4 passed in 0.67 seconds =========================== ============================= test session starts ============================== platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py ..... =========================== 5 passed in 0.72 seconds =========================== ============================= test session starts ============================== platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. =========================== 2 passed in 0.65 seconds =========================== src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS src.test.python.apache.aurora.client.cli.help ..... SUCCESS src.test.python.apache.aurora.client.cli.job ..... SUCCESS src.test.python.apache.aurora.client.cli.logging ..... SUCCESS src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS src.test.python.apache.aurora.client.cli.quota ..... SUCCESS src.test.python.apache.aurora.client.cli.sla ..... SUCCESS src.test.python.apache.aurora.client.cli.task ..... SUCCESS [sun-wukong incubator-aurora (command-hooks-two)]$ Thanks, Mark Chu-Carroll --===============6331514965856620723==--