Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 98BA5104E6 for ; Thu, 1 May 2014 17:01:47 +0000 (UTC) Received: (qmail 96183 invoked by uid 500); 1 May 2014 17:01:46 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 96142 invoked by uid 500); 1 May 2014 17:01:46 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 96124 invoked by uid 99); 1 May 2014 17:01:45 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 May 2014 17:01:45 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 01 May 2014 17:01:44 +0000 Received: (qmail 94837 invoked by uid 99); 1 May 2014 17:01:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 May 2014 17:01:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3F62E1D7341; Thu, 1 May 2014 17:01:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6681943232052763304==" MIME-Version: 1.0 Subject: Review Request 20950: Moving kill wait to the client (Part 1: client changes) From: "Maxim Khutornenko" To: "Brian Wickman" , "Mark Chu-Carroll" Cc: "Aurora" , "Maxim Khutornenko" Date: Thu, 01 May 2014 17:01:13 -0000 Message-ID: <20140501170113.16690.36473@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/20950/ X-Sender: "Maxim Khutornenko" Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6681943232052763304== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/ ----------------------------------------------------------- Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-370 https://issues.apache.org/jira/browse/AURORA-370 Repository: aurora Description ------- Migration plan: 1. Prepare client to poll for the status of tasks being killed. This is mostly a noop at this point while the scheduler wait with a shorter timeout is still in place. 2. Cut off scheduler killTasks wait thus relying on the client poll (coming next). This RB addresses client changes: - Repurposing JobMonitor to poll for all job tasks regardless of their arrival time. - Introducing a timeout cap into JobMonitor to interrupt wait upon reaching the max_poll_interval. - Setting the JobMonitor max_poll_interval to be higher than the scheduler killTasks backoff to ensure smooth migration. - Added wait_util calls into kill/killall/updater calls. Once this ticket is closed, the next step would be to make kill/killall truly async: AURORA-371 Diffs ----- src/main/python/apache/aurora/client/api/BUILD 32097d220a6f8a58555260ce081ace0c58b9fa99 src/main/python/apache/aurora/client/api/job_monitor.py b694ef62ba708c4b67c5cc931b0edfd93702027f src/main/python/apache/aurora/client/api/updater.py 0acf45034db124ed369d0bcb8095fe5545605eed src/main/python/apache/aurora/client/cli/jobs.py 782b34800def55c54b67ca5f13da66c4997a0777 src/main/python/apache/aurora/client/cli/task.py 62747ed3e3f5f6ecd9b9c46f6f175c634c068358 src/main/python/apache/aurora/client/commands/core.py 39190e06f3eac1ab4dabf48055418bc383be14ed src/test/python/apache/aurora/client/api/BUILD dd9b79764db0bbc3a11c51051e43b93a9b5d370a src/test/python/apache/aurora/client/api/test_job_monitor.py 32609e4e97afc7b8b164f3db438c60efd0ebbe11 src/test/python/apache/aurora/client/api/test_updater.py e7eb1e783baaabe9437e55ecb848f6a42de13dd7 src/test/python/apache/aurora/client/cli/test_command_hooks.py 7c6f70c7ef7534e9dd4986364331c67f6f7c36b1 src/test/python/apache/aurora/client/cli/test_create.py 875573e2ee534ea50da71fac2174ecc8877a714d src/test/python/apache/aurora/client/cli/test_kill.py cf5df648206e0cc234d603c1fd56dc7ab1311fa9 src/test/python/apache/aurora/client/cli/test_plugins.py 2dab749d1dcba99a1e3c792c8f26ee86441673d1 src/test/python/apache/aurora/client/cli/test_update.py cf077e821ebe32104b3e1345014f5c7b07c44c34 src/test/python/apache/aurora/client/cli/util.py 2225ab071dff72be547c43f66ffdc890171c3288 src/test/python/apache/aurora/client/commands/test_create.py e0ecb523db4ce3b1901adcc96a2fd5ce8184f621 src/test/python/apache/aurora/client/commands/test_kill.py db820a543b0ea11e5a40cc2a00209aa8fa6186c9 src/test/python/apache/aurora/client/commands/test_update.py 6e145db9ff8213c8f098b53b9a9668532d664249 Diff: https://reviews.apache.org/r/20950/diff/ Testing ------- ./pants src/test/python:all Thanks, Maxim Khutornenko --===============6681943232052763304==--