aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 22008: Exclude .git from rsync copy in vagrant.
Date Thu, 29 May 2014 11:58:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22008/#review44255
-----------------------------------------------------------


Why?

Right now, I do a lot of debugging of the client using vagrant. My typical workflow is:
- Make the change in my git workspace.
- Commit it to a branch.
- vagrant ssh into the virtual cluster
- git pull /vagrant mybranch
- build client
- test

If we eliminate that .git file, then the aurora copy in the vagrant host can no longer be
used for pulls. We can't just use the /vagrant copy, because that's got a ton of state.

With this change, to do a similar dev workflow, I'd need to create a git workspace cloned
from /vagrant, and also add new stuff to copy the resulting aurora/aurora2 pexes into the
original /vagrant copy. It makes the workflow more complicated, and I'm not clear on what
benefits it produces in exchange.





- Mark Chu-Carroll


On May 29, 2014, 12:43 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22008/
> -----------------------------------------------------------
> 
> (Updated May 29, 2014, 12:43 a.m.)
> 
> 
> Review request for Aurora and Mark Chu-Carroll.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Exclude .git from rsync copy in vagrant.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/provision-dev-cluster.sh ce936c19a42f4968d4706e6ef38c25db01ae2c5d

> 
> Diff: https://reviews.apache.org/r/22008/diff/
> 
> 
> Testing
> -------
> 
> vagrant up
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message