aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <ma...@apache.org>
Subject Re: Review Request 21825: Added tabs for active and completed tasks in Job page.
Date Wed, 28 May 2014 19:25:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21825/
-----------------------------------------------------------

(Updated May 28, 2014, 7:25 p.m.)


Review request for Aurora, David McLaughlin and Bill Farner.


Changes
-------

Rebased with master.


Bugs: AURORA-425
    https://issues.apache.org/jira/browse/AURORA-425


Repository: aurora


Description
-------

Moved task tables into active and completed tabs on job page. 
Installed angular-ui/bootstrap project since we need the tabset directive from it.
Upgraded angular js to version 1.2.9 from 1.2.6.


Diffs (updated)
-----

  3rdparty/javascript/bower_components/angular-bootstrap/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/angular-bootstrap/bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js PRE-CREATION

  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js PRE-CREATION

  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js PRE-CREATION 
  3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js PRE-CREATION

  3rdparty/javascript/bower_components/angular/.bower.json ee8284d59e3d13b2c9ea444caebf4b3d07323460

  3rdparty/javascript/bower_components/angular/angular.js d4d7abc0b72626c0c7028c8ac013f4218df71d07

  3rdparty/javascript/bower_components/angular/angular.min.js d3daf08b075b48d53860fd1c119ff736efa9f6c4

  3rdparty/javascript/bower_components/angular/angular.min.js.gzip 879a6b82f0f72cc79b06918150327fd025474adb

  3rdparty/javascript/bower_components/angular/angular.min.js.map 68739de57996eac63fbf4da9fd45fc93d80c899c

  3rdparty/javascript/bower_components/angular/bower.json 9079df91659e6965eeff30ae68e0c22211e2ab14

  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 5b25d52834cb3bf19dfa6ed49b35384f5c2323f2

  src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 9bd81601c8d0ba4296852b590d0266586e06b41b

  src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 9c468bdcd955ebd9d7a951094292df46f5e5bc67

  src/main/resources/org/apache/aurora/scheduler/http/ui/job.html a4b4ac7a772842311ede1e2d546cadd1d323b146

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js d52cdda655ac5a64f2520ae61808dc5562ce49e7

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js e239e7d994dff75988a45458a8a4e6f1f65c225d


Diff: https://reviews.apache.org/r/21825/diff/


Testing
-------

./gradlew run && ./gradlew build


File Attachments
----------------

 active tasks tab
  https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png
 completed tasks tab
  https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png
all tasks tab
  https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png
Tabs with task counts
  https://reviews.apache.org/media/uploaded/files/2014/05/23/c5a6a3c6-bef0-4726-ae2f-83bf8a575e61__Screen_Shot_2014-05-23_at_2.16.36_PM.png


Thanks,

Suman Karumuri


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message