aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <da...@dmclaughlin.com>
Subject Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)
Date Tue, 27 May 2014 21:59:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132/
-----------------------------------------------------------

(Updated May 27, 2014, 9:59 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
-------

Rebased.


Bugs: AURORA-335
    https://issues.apache.org/jira/browse/AURORA-335


Repository: aurora


Description
-------

Lays down the groundwork for h2/MyBatis integration in the aurora scheduler, and creates a
bridge so that the existing in-memory stores can co-exist with the new db stores. This allows
us to incrementally replace each storage implementation in org.apache.aurora.scheduler.storage.mem.
In this patch I have replaced MemLockStore with DbLockStore. 


Diffs (updated)
-----

  build.gradle 646cdd2ac7a0beef7df5d02f16b1d37defb0c109 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 80252bd5e1a48ada7fcd99ce7b25ee13e05e0410

  src/main/java/org/apache/aurora/scheduler/base/JobKeys.java ec5323259eb115030d12e20406675ff8ca435b74

  src/main/java/org/apache/aurora/scheduler/storage/Storage.java bbbd7dc58f3715e1adb98f2b2540a9d13127c64c

  src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/JobKeyMapper.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/LockKeyMapper.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/LockMapper.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/views/LockRow.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 7fcc0726a235f90f3d12df8d7d787cd34f80f889

  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 96da98976eeece6dde7187e976ec5dc8871b9032

  src/main/java/org/apache/aurora/scheduler/storage/mem/MemLockStore.java 1daab634d4a47064cdc1fa9dc5be133d5605ecea

  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 4a7db20d45e068c954fc5c65805555a9bcfdd653

  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 6137f5bbf00931c0cc678f7735d77dbf32aac09a

  src/main/resources/org/apache/aurora/scheduler/storage/db/JobKeyMapper.xml PRE-CREATION

  src/main/resources/org/apache/aurora/scheduler/storage/db/LockMapper.xml PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 6f6d9a46bd78c8e96c69240be8cb9ac6d564f0f8

  src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java d4fe607f2881a628ac4dc017fbed02a9509f2ce2


Diff: https://reviews.apache.org/r/21132/diff/


Testing
-------

./gradlew clean build


Thanks,

David McLaughlin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message