aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.
Date Fri, 23 May 2014 18:38:27 GMT


> On May 23, 2014, 12:07 a.m., Maxim Khutornenko wrote:
> > This will not pass python tests as we reference resp.message in quite a few places.

Doh!  You're right, i published this in haste before leaving the office.  I'll fix that up
shortly.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21830/#review43796
-----------------------------------------------------------


On May 22, 2014, 9:58 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21830/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 9:58 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-461
>     https://issues.apache.org/jira/browse/AURORA-461
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This also included a small amount of cleanup in the aop package, since we now use a uniform
response type.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 88bd20d55b488b30dba70d8c1469e058d1c761bc

>   src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java
2134609769d74755d11b43015bd1d17ad49132ec 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java ee22af10a469db1a3cc46d9092285977b5526f9e

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 5f8143c146a25196d6ecc10d93c8e8e99d4e06be

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java
801e7ae7c8fc5fa5d5e1f9934a34f8e809aa0798 
>   src/main/thrift/org/apache/aurora/gen/api.thrift aad74fd6db573f1502c54fa31f7aa5ee53cf9ad4

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
a9e5d89465a14c0d8bd4540b34e311763357f78f 
> 
> Diff: https://reviews.apache.org/r/21830/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message