aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 21741: Adding grouping for the sla commands.
Date Thu, 22 May 2014 19:23:20 GMT


> On May 22, 2014, 4:22 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/base.py, line 118
> > <https://reviews.apache.org/r/21741/diff/1/?file=585847#file585847line118>
> >
> >     can you also add register_grouping() that associates a name with a function?
 this way it's explicit and not monkeypatched.

Good idea. Done.


> On May 22, 2014, 4:22 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/base.py, line 123
> > <https://reviews.apache.org/r/21741/diff/1/?file=585847#file585847line123>
> >
> >     It would be helpful to also print out GROUPING_FUNCTIONS.keys()

Done.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/#review43728
-----------------------------------------------------------


On May 21, 2014, 12:24 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21741/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 12:24 a.m.)
> 
> 
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
> 
> 
> Bugs: AURORA-441
>     https://issues.apache.org/jira/browse/AURORA-441
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Moved grouping functionality from maintenance into base and added grouping support for
the sla commands.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 16c18bc563c61e37055a8ad81082d60d1662afb2

>   src/main/python/apache/aurora/client/api/sla.py a20b5d46221981740e0b7d5f0958516560928b54

>   src/main/python/apache/aurora/client/base.py 13730fd98e36377376e498f414dfb317d5b3b114

>   src/main/python/apache/aurora/client/commands/admin.py 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02

>   src/main/python/apache/aurora/client/commands/maintenance.py 68d63a12bb92bb2f50ae45363513892ad9bbb1ff

>   src/test/python/apache/aurora/admin/test_host_maintenance.py 18bf6223adb6b64cc76c2810abc317ef063e16e2

>   src/test/python/apache/aurora/client/api/test_sla.py 86b6775e51cab1214a6cae01145f19f08cc74499

>   src/test/python/apache/aurora/client/commands/test_admin_sla.py df007f2e0de70cd6c3295119d7ef3877cfce036d

> 
> Diff: https://reviews.apache.org/r/21741/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message