aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <da...@dmclaughlin.com>
Subject Re: Review Request 21753: Enable a few checkstyle checks.
Date Wed, 21 May 2014 18:32:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21753/#review43644
-----------------------------------------------------------

Ship it!


- David McLaughlin


On May 21, 2014, 5:13 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21753/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 5:13 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Enable a few checkstyle checks.
> 
> 
> Diffs
> -----
> 
>   config/checkstyle/checkstyle.xml 8e869f3e7569f1f02dd206c4f396e066ec2aae5c 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java e599cac5c9c24a32feffe120a2d71355ba048a27

>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java b85e42b41e1466213be0e6a25c39f5b0d78cd53e

>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java f7f418a8c8d1d3150f8f3b7c8b60da634ec2484f

>   src/main/java/org/apache/aurora/scheduler/base/ResourceAggregates.java 7804300ca984a3e9f5004aba51643fe5e64bae1f

>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 5e3015dc9aa63c59d3ba8ae7b3e885e76f76174e

>   src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 64112448fc38f21cf2f8b178c6ef9130fc100938

>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 155fdd1e31bf52b61aab0ebbffb5264af644a38c

>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java d377974da4f7efa7f47e06702654bc786299e01c

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 4386a86c0aebdb9666c0232672f8c1bab7458f47

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java bf1391e671fdbc1c2ff4f6dd0c3d7788aed33abf

>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
05e80e8f6f6030c3a48e54303aae0b0642acb7e7 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java b4aeaf2b439117f29f2564c3c4eed0d2f002f7ae

>   src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java b985fbb897a6eafb55a921a0e00857805e741a03

> 
> Diff: https://reviews.apache.org/r/21753/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message