aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Re: Review Request 20285: Improve documentation and testing for host maintenance API
Date Wed, 21 May 2014 03:51:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20285/
-----------------------------------------------------------

(Updated May 20, 2014, 8:51 p.m.)


Review request for Aurora, David Robinson, Kevin Sweeney, Tobias Weingartner, and Bill Farner.


Changes
-------

Kevin, dRob, and Toby, could I get a look at this by the EOW? I'd really like to get this
shipped and prevent it from slipping back into bit rot.


Bugs: AURORA-318
    https://issues.apache.org/jira/browse/AURORA-318


Repository: aurora


Description
-------

Add way more docstrings as  well as unit tests for the HostMaintenance api.


Diffs (updated)
-----

  src/main/python/apache/aurora/admin/host_maintenance.py 16c18bc563c61e37055a8ad81082d60d1662afb2

  src/test/python/apache/aurora/admin/BUILD 17aac54d636024a8e131eb2e4d996c2e15401de1 
  src/test/python/apache/aurora/admin/test_host_maintenance.py 18bf6223adb6b64cc76c2810abc317ef063e16e2


Diff: https://reviews.apache.org/r/20285/diff/


Testing
-------

16:39:58 incubator-aurora $ ./pants ./src/test/python/apache/aurora/admin:all
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/admin/BUILD:all)])
============================================================================================================
test session starts =============================================================================================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 9 items 

src/test/python/apache/aurora/admin/test_host_maintenance.py .........

==========================================================================================================
9 passed in 0.67 seconds ==========================================================================================================
src.test.python.apache.aurora.admin.host_maintenance                            .....   SUCCESS


Thanks,

Joe Smith


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message