aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <>
Subject Re: Review Request 21497: Add CORS support to thrift end points.
Date Wed, 21 May 2014 02:10:11 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 21, 2014, 2:10 a.m.)

Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.


Addressed Bill's comments. Now applying filter using filter().through. Since we can't use
multiple JersyServletModule in the same application, moved ServletAPI registration into ServletModule.

Bugs: AURORA-390

Repository: aurora


Add CORS support for thrift end points. Added a command line option to explicitly enable that
support since this may a potential security issue and we may not want to enable it in production.

Diffs (updated)

  build.gradle 09fe3bfc5ec535c6bdc8efeb87b0c7e3baf123c5 
  src/main/java/org/apache/aurora/scheduler/http/ PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/ effd48a95da459f92ed0f38a7bc35fe9e33b774a

  src/main/java/org/apache/aurora/scheduler/thrift/ a92525bd45bd297f7384651586738934a5639e1b

  src/main/java/org/apache/aurora/scheduler/thrift/ fc5610ec4483bf236da39cb31c0756934b6d264f



Local laptop. Attached screenshot.
Called the API from another JS app and was able to make a successful $

File Attachments

cors with whitelisted domains
disabled cors.
cors with default whitelist.


Suman Karumuri

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message