aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 21597: Return empty list instead of failing.
Date Wed, 21 May 2014 01:38:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21597/#review43569
-----------------------------------------------------------



src/main/python/apache/aurora/client/base.py
<https://reviews.apache.org/r/21597/#comment77810>

    Why are these split into multiple methods? The only place where "check_and_log_locked"
is used is right here.
    


- Mark Chu-Carroll


On May 19, 2014, 1:58 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21597/
> -----------------------------------------------------------
> 
> (Updated May 19, 2014, 1:58 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-442
>     https://issues.apache.org/jira/browse/AURORA-442
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Mistyped or unknown to scheduler hosts should not result in failing the SLA command.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/sla.py a20b5d46221981740e0b7d5f0958516560928b54

>   src/main/python/apache/aurora/client/base.py 13730fd98e36377376e498f414dfb317d5b3b114

>   src/test/python/apache/aurora/client/api/test_sla.py 86b6775e51cab1214a6cae01145f19f08cc74499

> 
> Diff: https://reviews.apache.org/r/21597/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message