aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <da...@dmclaughlin.com>
Subject Review Request 21523: Make JS compliant with JSHint rules
Date Fri, 16 May 2014 01:25:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/
-----------------------------------------------------------

Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.


Repository: aurora


Description
-------

Make JS compliant with JSHint rules


Add JSHint to our build.

Right now it does not break the build when JSHint fails.
Will fix the errors in a separate review.

Testing Done:
./gradlew clean build works.

Bugs closed: AURORA-228

Reviewed at https://reviews.apache.org/r/21407/

Add config grouping visualisation to job page

Replace the button to show/hide configs with a bar when there are multiple.
Tidied up the display of the configuration data.

Bugs closed: AURORA-378

Reviewed at https://reviews.apache.org/r/21247/


Diffs
-----

  build.gradle ac54257a0342e1f1a162189191d5f7b27e1651c9 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 1a617129da4747584df1b49c34ffcaa4b505d3dc

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 890cb445aaed29d60d1728c2ad10074912993ad8

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js a2aea4d10e4401efebe37eab10d5ce72ceb5c6ca

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js f984956c90e1db38573a56af3427f2f948f13692


Diff: https://reviews.apache.org/r/21523/diff/


Testing
-------


Thanks,

David McLaughlin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message