aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <>
Subject Re: Review Request 21250: Removed cron jobs table from role and env page. Added cron job summary to job page.
Date Thu, 15 May 2014 21:07:13 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 15, 2014, 9:07 p.m.)

Review request for Aurora, David McLaughlin and Bill Farner.


Addressed code review comments.

Bugs: AURORA-384

Repository: aurora


Removed cron jobs table from role and env pages.
Added cron job summary to job page.
Updated getTasksQuery to not throw an exception when requesting a cron job with no tasks.

Diffs (updated)

  src/main/java/org/apache/aurora/scheduler/thrift/ 9bb5c255e1118038b953fc72f0a074d461ba1fb5

  src/main/resources/org/apache/aurora/scheduler/http/ui/job.html cd78c20bee7891a6cdfd19943a6f7e8a9dce33df

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 768c4fe0db2813c50400370390a34cd428f88df5

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 2e8b73b6c4430b65649c81da6090875fd15e29a2

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js feb9ece3ec324840c33e0449f27e9914480aa061

  src/main/resources/org/apache/aurora/scheduler/http/ui/role.html 94fda639b3ccd330a726fe963df21aa07e74b6da



Tested on local laptop.
./gradlew clean build.
./pants src/test/python:all -vxs

File Attachments

Job summary for non-cron job.
Role page without cron jobs
Job page of a cron job.
cron job page with expanded show summary.


Suman Karumuri

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message