aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jake Farrell" <jfarr...@apache.org>
Subject Re: Review Request 19796: AURORA-145:Test dependencies leak into distribution
Date Thu, 15 May 2014 02:22:53 GMT


> On April 1, 2014, 3:38 p.m., Bill Farner wrote:
> > Just for clarity — i'll review/ship this once https://reviews.apache.org/r/19767/
is on master.
> 
> Jake Farrell wrote:
>     This patch remains the same with the recently committed (and then reverted) cron
updates.
>     
>     After this patch FileLogStreamModule.java will be the last testing dep in main, unless
we count FakeClock (from twitter.commons util-testing)

bump, any objections on this?


- Jake


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19796/#review39162
-----------------------------------------------------------


On March 28, 2014, 7:28 p.m., Jake Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19796/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 7:28 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-145
>     https://issues.apache.org/jira/browse/AURORA-145
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-145:Test dependencies leak into distribution
> 
> Moves testing dependencies out of main src into test.
> 
> 
> Diffs
> -----
> 
>   build.gradle f10f22cb27dca28d1087a03b12d0defcaf1a7836 
>   src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java  
>   src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java  
> 
> Diff: https://reviews.apache.org/r/19796/diff/
> 
> 
> Testing
> -------
> 
> Was initially waiting on AURORA-132 for this. ran build-support/jenkins/build.sh and
created dists with no issues.
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message