aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 21297: Adding UpdateConfig value checks.
Date Wed, 14 May 2014 22:55:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21297/#review43048
-----------------------------------------------------------



src/main/python/apache/aurora/client/config.py
<https://reviews.apache.org/r/21297/#comment77053>

    How about adding a couple-second delay to account for executor bootup time. Ideally we'd
be able to know when the executor started its stopwatch but in absence of that information
we can fuzz it with a few second sleep.


- Kevin Sweeney


On May 14, 2014, 3:35 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21297/
> -----------------------------------------------------------
> 
> (Updated May 14, 2014, 3:35 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: AURORA-404
>     https://issues.apache.org/jira/browse/AURORA-404
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding checks for watch_secs, initial_interval_secs and restart_threshold.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/config.py 350d84c97fac9f1dd834bf509a160faaacb26386

>   src/main/python/apache/aurora/config/__init__.py 74e6b21ef905221cb3beb974a540325937480f2e

>   src/main/python/apache/aurora/config/schema/base.py 61a6680f8b1a463055ccd6d318cc540aca166684

>   src/test/python/apache/aurora/client/cli/util.py e17f256fc5d17f251e8f2cb4d94233d2d6c09897

>   src/test/python/apache/aurora/client/commands/util.py c28096fe89c9af6d5518bc0f8f871e886ca12e7f

>   src/test/python/apache/aurora/client/test_config.py 8ef08685c317c3f9dae799dfb6bdced7077a8778

> 
> Diff: https://reviews.apache.org/r/21297/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message