aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 21460: Removed trailing / from /api end point.
Date Wed, 14 May 2014 21:58:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21460/#review43034
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java
<https://reviews.apache.org/r/21460/#comment77029>

    You definitely don't need two lines, since this is a servlet URL pattern.  If Suman observed
this working, i'm willing to trust him.
    
    I always seem to have trouble finding canonical docs on servlet URL patterns, but here's
something: http://www.roguewave.com/portals/0/products/hydraexpress/docs/3.5.0/html/rwsfservletug/4-3.html


- Bill Farner


On May 14, 2014, 9:42 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21460/
> -----------------------------------------------------------
> 
> (Updated May 14, 2014, 9:42 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removed trailing / from /api end point. Fixing a bad merge from https://reviews.apache.org/r/18658/
> 
> Removing the /, re-enables the gzip encryption.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java c14d5c2d059e8970b2f232b7a2a0958ba8cffcb8

>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js feb9ece3ec324840c33e0449f27e9914480aa061

> 
> Diff: https://reviews.apache.org/r/21460/diff/
> 
> 
> Testing
> -------
> 
> Tested on laptop.
> 
> 
> File Attachments
> ----------------
> 
> gzip encoded /api end point
>   https://reviews.apache.org/media/uploaded/files/2014/05/14/2ea6ea61-0740-491c-a016-596888f56b7c__Screen_Shot_2014-05-14_at_2.26.17_PM.png
> Enabled gzip encoding for /api/  end point.
>   https://reviews.apache.org/media/uploaded/files/2014/05/14/637c4f85-7d22-49c1-89fc-7fea74f36b29__Screen_Shot_2014-05-14_at_2.37.49_PM.png
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message