aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 21205: Bugfix: restart doesn't notify user about invalid max_total_failures option.
Date Tue, 13 May 2014 19:18:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21205/
-----------------------------------------------------------

(Updated May 13, 2014, 3:18 p.m.)


Review request for Aurora, David McLaughlin and Suman Karumuri.


Changes
-------

Rebase to master.


Bugs: aurora-399
    https://issues.apache.org/jira/browse/aurora-399


Repository: aurora


Description
-------

Bugfix: restart doesn't notify user about invalid max_total_failures option.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/jobs.py 6fc08dacf1ec1242bc30512fe566a541140feef5

  src/main/python/apache/aurora/client/commands/core.py 4ce60351f8578b46e9f5ee1b0c04e89f8007d595

  src/test/python/apache/aurora/client/cli/test_restart.py d365ef438b35cb0e87e33b6f02301236dc01fd2a

  src/test/python/apache/aurora/client/commands/test_restart.py fba529f187be8ad82c187296b74d135f63164348


Diff: https://reviews.apache.org/r/21205/diff/


Testing
-------

[sun-wukong incubator-aurora (restart_max)]$ ./pants src/test/python/apache/aurora/client:all
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 2 items

src/test/python/apache/aurora/client/test_binding_helper.py ..

=================================== 2 passed in 0.36 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 6 items

src/test/python/apache/aurora/client/test_config.py ......

=================================== 6 passed in 0.45 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 6 items

src/test/python/apache/aurora/client/api/test_disambiguator.py ......

=================================== 6 passed in 0.41 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/api/test_job_monitor.py ....

=================================== 4 passed in 0.39 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 6 items

src/test/python/apache/aurora/client/api/test_restarter.py ......

=================================== 6 passed in 0.34 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 47 items / 1 skipped

src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................

============================= 47 passed, 1 skipped in 4.05 seconds ==============================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 12 items

src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
src/test/python/apache/aurora/client/api/test_health_check.py ....

=================================== 12 passed in 0.22 seconds ===================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 28 items

src/test/python/apache/aurora/client/api/test_updater.py ............................

=================================== 28 passed in 0.67 seconds ===================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 6 items

src/test/python/apache/aurora/client/api/test_quota_check.py ......

=================================== 6 passed in 0.14 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 33 items

src/test/python/apache/aurora/client/api/test_sla.py .................................

=================================== 33 passed in 0.29 seconds ===================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py ....

=================================== 4 passed in 0.02 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 9 items

src/test/python/apache/aurora/client/cli/test_command_hooks.py .........

=================================== 9 passed in 0.75 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .....

=================================== 5 passed in 0.61 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 38 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py ..........
src/test/python/apache/aurora/client/cli/test_open.py .....
src/test/python/apache/aurora/client/cli/test_restart.py ....
src/test/python/apache/aurora/client/cli/test_status.py .......
src/test/python/apache/aurora/client/cli/test_update.py ...

=================================== 38 passed in 2.01 seconds ===================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=================================== 1 passed in 0.64 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items

src/test/python/apache/aurora/client/cli/test_plugins.py ...

=================================== 3 passed in 0.66 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/cli/test_quota.py ....

=================================== 4 passed in 0.64 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items

src/test/python/apache/aurora/client/cli/test_sla.py .....

=================================== 5 passed in 0.66 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 2 items

src/test/python/apache/aurora/client/cli/test_task_run.py ..

=================================== 2 passed in 0.63 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 13 items

src/test/python/apache/aurora/client/commands/test_admin_sla.py .............

=================================== 13 passed in 0.49 seconds ===================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 30 items

src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ........
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ...
src/test/python/apache/aurora/client/commands/test_update.py ...

=================================== 30 passed in 1.36 seconds ===================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items

src/test/python/apache/aurora/client/commands/test_hooks.py ...

=================================== 3 passed in 1.02 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/commands/test_maintenance.py ....

=================================== 4 passed in 0.46 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 1 items

src/test/python/apache/aurora/client/commands/test_run.py .

=================================== 1 passed in 0.45 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 1 items

src/test/python/apache/aurora/client/commands/test_ssh.py .

=================================== 1 passed in 0.46 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 12 items

src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............

=================================== 12 passed in 0.45 seconds ===================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....

=================================== 4 passed in 0.41 seconds ====================================
src.test.python.apache.aurora.client.api.disambiguator                          .....   SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher                       .....   SUCCESS
src.test.python.apache.aurora.client.api.job_monitor                            .....   SUCCESS
src.test.python.apache.aurora.client.api.quota_check                            .....   SUCCESS
src.test.python.apache.aurora.client.api.restarter                              .....   SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client                       .....   SUCCESS
src.test.python.apache.aurora.client.api.sla                                    .....   SUCCESS
src.test.python.apache.aurora.client.api.updater                                .....   SUCCESS
src.test.python.apache.aurora.client.binding_helper                             .....   SUCCESS
src.test.python.apache.aurora.client.cli.bridge                                 .....   SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks                          .....   SUCCESS
src.test.python.apache.aurora.client.cli.help                                   .....   SUCCESS
src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS
src.test.python.apache.aurora.client.cli.logging                                .....   SUCCESS
src.test.python.apache.aurora.client.cli.plugins                                .....   SUCCESS
src.test.python.apache.aurora.client.cli.quota                                  .....   SUCCESS
src.test.python.apache.aurora.client.cli.sla                                    .....   SUCCESS
src.test.python.apache.aurora.client.cli.task                                   .....   SUCCESS
src.test.python.apache.aurora.client.commands.admin                             .....   SUCCESS
src.test.python.apache.aurora.client.commands.core                              .....   SUCCESS
src.test.python.apache.aurora.client.commands.hooks                             .....   SUCCESS
src.test.python.apache.aurora.client.commands.maintenance                       .....   SUCCESS
src.test.python.apache.aurora.client.commands.run                               .....   SUCCESS
src.test.python.apache.aurora.client.commands.ssh                               .....   SUCCESS
src.test.python.apache.aurora.client.config                                     .....   SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api                           .....   SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api                       .....   SUCCESS
[sun-wukong incubator-aurora (restart_max)]$ ./pants src/test/python/apache/aurora/client:all
Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 2 items

src/test/python/apache/aurora/client/test_binding_helper.py ..

=================================== 2 passed in 0.35 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 6 items

src/test/python/apache/aurora/client/test_config.py ......

=================================== 6 passed in 0.45 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 6 items

src/test/python/apache/aurora/client/api/test_disambiguator.py ......

=================================== 6 passed in 0.39 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/api/test_job_monitor.py ....

=================================== 4 passed in 0.52 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 6 items

src/test/python/apache/aurora/client/api/test_restarter.py ......

=================================== 6 passed in 0.35 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 47 items / 1 skipped

src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................

============================= 47 passed, 1 skipped in 3.64 seconds ==============================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 12 items

src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
src/test/python/apache/aurora/client/api/test_health_check.py ....

=================================== 12 passed in 0.23 seconds ===================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 28 items

src/test/python/apache/aurora/client/api/test_updater.py ............................

=================================== 28 passed in 0.67 seconds ===================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 6 items

src/test/python/apache/aurora/client/api/test_quota_check.py ......

=================================== 6 passed in 0.15 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 33 items

src/test/python/apache/aurora/client/api/test_sla.py .................................

=================================== 33 passed in 0.26 seconds ===================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/cli/test_bridge.py ....

=================================== 4 passed in 0.02 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 9 items

src/test/python/apache/aurora/client/cli/test_command_hooks.py .........

=================================== 9 passed in 0.71 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items

src/test/python/apache/aurora/client/cli/test_help.py .....

=================================== 5 passed in 0.60 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 38 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py ..........
src/test/python/apache/aurora/client/cli/test_open.py .....
src/test/python/apache/aurora/client/cli/test_restart.py ....
src/test/python/apache/aurora/client/cli/test_status.py .......
src/test/python/apache/aurora/client/cli/test_update.py ...

=================================== 38 passed in 1.94 seconds ===================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 1 items

src/test/python/apache/aurora/client/cli/test_logging.py .

=================================== 1 passed in 0.62 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items

src/test/python/apache/aurora/client/cli/test_plugins.py ...

=================================== 3 passed in 0.65 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/cli/test_quota.py ....

=================================== 4 passed in 0.63 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items

src/test/python/apache/aurora/client/cli/test_sla.py .....

=================================== 5 passed in 0.67 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 2 items

src/test/python/apache/aurora/client/cli/test_task_run.py ..

=================================== 2 passed in 0.73 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 13 items

src/test/python/apache/aurora/client/commands/test_admin_sla.py .............

=================================== 13 passed in 0.50 seconds ===================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 31 items

src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ........
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ....
src/test/python/apache/aurora/client/commands/test_status.py ...
src/test/python/apache/aurora/client/commands/test_update.py ...

=================================== 31 passed in 1.57 seconds ===================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items

src/test/python/apache/aurora/client/commands/test_hooks.py ...

=================================== 3 passed in 1.02 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/commands/test_maintenance.py ....

=================================== 4 passed in 0.46 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 1 items

src/test/python/apache/aurora/client/commands/test_run.py .

=================================== 1 passed in 0.45 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 1 items

src/test/python/apache/aurora/client/commands/test_ssh.py .

=================================== 1 passed in 0.46 seconds ====================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 12 items

src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............

=================================== 12 passed in 0.44 seconds ===================================
====================================== test session starts ======================================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items

src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....

=================================== 4 passed in 0.41 seconds ====================================
src.test.python.apache.aurora.client.api.disambiguator                          .....   SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher                       .....   SUCCESS
src.test.python.apache.aurora.client.api.job_monitor                            .....   SUCCESS
src.test.python.apache.aurora.client.api.quota_check                            .....   SUCCESS
src.test.python.apache.aurora.client.api.restarter                              .....   SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client                       .....   SUCCESS
src.test.python.apache.aurora.client.api.sla                                    .....   SUCCESS
src.test.python.apache.aurora.client.api.updater                                .....   SUCCESS
src.test.python.apache.aurora.client.binding_helper                             .....   SUCCESS
src.test.python.apache.aurora.client.cli.bridge                                 .....   SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks                          .....   SUCCESS
src.test.python.apache.aurora.client.cli.help                                   .....   SUCCESS
src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS
src.test.python.apache.aurora.client.cli.logging                                .....   SUCCESS
src.test.python.apache.aurora.client.cli.plugins                                .....   SUCCESS
src.test.python.apache.aurora.client.cli.quota                                  .....   SUCCESS
src.test.python.apache.aurora.client.cli.sla                                    .....   SUCCESS
src.test.python.apache.aurora.client.cli.task                                   .....   SUCCESS
src.test.python.apache.aurora.client.commands.admin                             .....   SUCCESS
src.test.python.apache.aurora.client.commands.core                              .....   SUCCESS
src.test.python.apache.aurora.client.commands.hooks                             .....   SUCCESS
src.test.python.apache.aurora.client.commands.maintenance                       .....   SUCCESS
src.test.python.apache.aurora.client.commands.run                               .....   SUCCESS
src.test.python.apache.aurora.client.commands.ssh                               .....   SUCCESS
src.test.python.apache.aurora.client.config                                     .....   SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api                           .....   SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api                       .....   SUCCESS
[sun-wukong incubator-aurora (restart_max)] $


Thanks,

Mark Chu-Carroll


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message