aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 21386: Add support for custom project to list-missing-shipits
Date Tue, 13 May 2014 18:24:05 GMT


> On May 13, 2014, 11:07 a.m., Bill Farner wrote:
> > build-support/tools/list-missing-shipits, line 94
> > <https://reviews.apache.org/r/21386/diff/1/?file=580750#file580750line94>
> >
> >     At a quick glance, it's not obvious how this relates to plumbing the 'project'
argument.  Was there another issue you bumped into?  Is this so you can use the script outside
the repo?
> 
> Dominic Hamon wrote:
>     yes - other projects don't have rbt in the specific path the script was pointing
at.
>     
>     I considered keeping this as the default if 'rbt' isn't found on the path but thought
that might be flaky.

FWIW I'd highly recommend the aurora approach (self-bootstrapping, isolated rbt) over requiring
a global installation of it with pip, since you get to explicitly specify the target version
and it's one less barrier to entry for new contributors. To get this in another repo you'd
want to copy ./rbt, ./build-support/virtualenv, and ./build-support/tools/list-missing-shipits.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/#review42853
-----------------------------------------------------------


On May 13, 2014, 11:07 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21386/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 11:07 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add support for custom project to list-missing-shipits.
> Search for rbt on PATH.
> 
> 
> Diffs
> -----
> 
>   build-support/tools/list-missing-shipits 33a4c412092a5a9a21ed8e5aaee69989535a12e7 
> 
> Diff: https://reviews.apache.org/r/21386/diff/
> 
> 
> Testing
> -------
> 
> Ran script against project Mesos.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message