aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <da...@dmclaughlin.com>
Subject Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)
Date Tue, 13 May 2014 17:49:55 GMT


> On May 12, 2014, 8:16 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java, line
108
> > <https://reviews.apache.org/r/21132/diff/2/?file=577940#file577940line108>
> >
> >     this function would help cut down a bunch of redundancy in this class:
> >     
> >       private static ILock makeLock(JobKey job) {
> >         ...
> >       }
> 
> David McLaughlin wrote:
>     ack. 
>     
>     Since it is useful to be able to differentiate between two locks (and we do this
in at least one test), I'm going to add two methods. One which returns a Lock and one which
returns an ILock. 
>     
>

Err, scratch that - realised there was no need for the two different tokens on those locks.
So now just makeLock. 


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132/#review42729
-----------------------------------------------------------


On May 13, 2014, 5:49 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21132/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 5:49 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
> 
> 
> Bugs: AURORA-335
>     https://issues.apache.org/jira/browse/AURORA-335
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Initial attempt at h2/DB storage implementation (LockStore only)
> 
> 
> Diffs
> -----
> 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8

>   src/main/java/org/apache/aurora/scheduler/base/JobKeys.java db1bec4f508c8908f212aa541fb86e041a8c471c

>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 4b33fe5dd8223ff04060de0fe16b1c0759ead956

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/JobKeyMapper.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/storage/db/LockMapper.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/storage/db/views/LockRow.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java c851eeb412b17097ff42abce2b7a42fc1c249013

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 4d43f47de75a8bef06f106f563cc071df4cdf093

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemLockStore.java a6319f65bff07db66197e6476647117df6be5c9d

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 283976ab0554dbe6700bb0d2a1b7702c969227e8

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 53923627c827131ee4bd93e5c4865d042aee501b

>   src/main/resources/org/apache/aurora/scheduler/storage/db/JobKeyMapper.xml PRE-CREATION

>   src/main/resources/org/apache/aurora/scheduler/storage/db/LockMapper.xml PRE-CREATION

>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 34377430268002e8e8e5bc803b409e092bb86720

>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java a5191500b2958253e14843089a15a1ffd58e6846

> 
> Diff: https://reviews.apache.org/r/21132/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message