aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <ma...@apache.org>
Subject Re: Review Request 21250: Removed cron jobs table from role and env page. Added cron job summary to job page.
Date Tue, 13 May 2014 01:13:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21250/
-----------------------------------------------------------

(Updated May 13, 2014, 1:12 a.m.)


Review request for Aurora, David McLaughlin and Bill Farner.


Bugs: AURORA-384
    https://issues.apache.org/jira/browse/AURORA-384


Repository: aurora


Description
-------

Removed cron jobs table from role and env pages.
Added cron job summary to job page.
Updated getTasksQuery to not throw an exception when requesting a cron job with no tasks.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9bb5c255e1118038b953fc72f0a074d461ba1fb5

  src/main/resources/org/apache/aurora/scheduler/http/ui/job.html cd78c20bee7891a6cdfd19943a6f7e8a9dce33df

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 768c4fe0db2813c50400370390a34cd428f88df5

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 2e8b73b6c4430b65649c81da6090875fd15e29a2

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js feb9ece3ec324840c33e0449f27e9914480aa061

  src/main/resources/org/apache/aurora/scheduler/http/ui/role.html 94fda639b3ccd330a726fe963df21aa07e74b6da


Diff: https://reviews.apache.org/r/21250/diff/


Testing
-------

Tested on local laptop.
./gradlew clean build.
./pants src/test/python:all -vxs


File Attachments (updated)
----------------

Job summary for non-cron job.
  https://reviews.apache.org/media/uploaded/files/2014/05/11/1196a4d3-a5bf-46a4-999c-be70c5a50d2e__Screen_Shot_2014-05-11_at_1.38.02_PM.png
job summary of cron job
  https://reviews.apache.org/media/uploaded/files/2014/05/11/83dfad8c-4115-483d-91e0-b8da941a0fb0__Screen_Shot_2014-05-11_at_1.37.54_PM.png
Role page without cron jobs
  https://reviews.apache.org/media/uploaded/files/2014/05/12/2d4639f9-2eb0-4180-a7a6-9fb69568ddbc__Screen_Shot_2014-05-12_at_11.47.27_AM.png
Cron job page with task summary open
  https://reviews.apache.org/media/uploaded/files/2014/05/13/eb16f07d-2ea8-4fe3-a9f8-5e1657a530b0__Screen_Shot_2014-05-12_at_6.07.50_PM.png


Thanks,

Suman Karumuri


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message