aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 21136: Add python import order wrapper/commit hook
Date Mon, 12 May 2014 18:59:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21136/#review42730
-----------------------------------------------------------

Ship it!


Ship It!


.isort.cfg
<https://reviews.apache.org/r/21136/#comment76584>

    Mind adding a comment indicating what this is?


- Kevin Sweeney


On May 12, 2014, 10:25 a.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21136/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 10:25 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-149
>     https://issues.apache.org/jira/browse/AURORA-149
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adds build-support/isort wrapper for isort.
> Adds build-support/isort-run to run import sort, build-support/isort-check to run import
order check.
> Adds build-support/hooks which contains hooks that people can place into their .git/hooks
directory, currently just a pre-commit hook that checks import sort order (which can be overridden
with an environment variable.)
> 
> The ordering it produces is different than the one we currently have but closer to straight
PEP8.  If it runs, it's about a 500 line diff which I can send later.
> 
> 
> Diffs
> -----
> 
>   .isort.cfg PRE-CREATION 
>   build-support/hooks/pre-commit PRE-CREATION 
>   build-support/isort PRE-CREATION 
>   build-support/isort-check PRE-CREATION 
>   build-support/isort-run PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21136/diff/
> 
> 
> Testing
> -------
> 
> Ran the isort and ran tests, everything worked.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message