aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <da...@dmclaughlin.com>
Subject Re: Review Request 21170: Make the "task run" command accept an instances spec.
Date Fri, 09 May 2014 18:18:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21170/#review42587
-----------------------------------------------------------

Ship it!


- David McLaughlin


On May 7, 2014, 6:48 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21170/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 6:48 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-198
>     https://issues.apache.org/jira/browse/aurora-198
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Make the "task run" command accept an instances spec.
> 
> Also, add a subclass of DistributedCommandRunner that takes an instance list, and runs
a command
> only on the specific task instances in that list.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/command_runner.py 1af6a782d6c0c419702ebfe0935eebbba0ea888a

>   src/main/python/apache/aurora/client/cli/options.py 040c5c213798e644ba59c4ce3f9c4fe8868af2d5

>   src/main/python/apache/aurora/client/cli/task.py a162b86e465991f14160ceff465ddd7d110b57a3

>   src/test/python/apache/aurora/client/cli/test_task_run.py fba812efc2292be3d66cb821f0877b60afa28072

> 
> Diff: https://reviews.apache.org/r/21170/diff/
> 
> 
> Testing
> -------
> 
> [sun-wukong incubator-aurora (run_with_instances)]$ ./pants src/test/python/apache/aurora/client/cli:task
> Build operating on targets: OrderedSet([PythonTests(src/test/python/apache/aurora/client/cli/BUILD:task)])
> ============================== test session starts ===============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ...
> 
> ============================ 3 passed in 0.64 seconds ============================
> src.test.python.apache.aurora.client.cli.task                                   .....
  SUCCESS
> [sun-wukong incubator-aurora (run_with_instances)]$
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message