aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Review Request 21136: Add python import order wrapper/commit hook
Date Tue, 06 May 2014 23:09:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21136/
-----------------------------------------------------------

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
-------

Adds build-support/isort wrapper for isort.
Adds build-support/isort-run to run import sort, build-support/isort-check to run import order
check.
Adds build-support/hooks which contains hooks that people can place into their .git/hooks
directory, currently just a pre-commit hook that checks import sort order (which can be overridden
with an environment variable.)

The ordering it produces is different than the one we currently have but closer to straight
PEP8.  If it runs, it's about a 500 line diff which I can send later.


Diffs
-----

  build-support/hooks/pre-commit PRE-CREATION 
  build-support/isort PRE-CREATION 
  build-support/isort-check PRE-CREATION 
  build-support/isort-run PRE-CREATION 
  src/.isort.cfg PRE-CREATION 

Diff: https://reviews.apache.org/r/21136/diff/


Testing
-------

Ran the isort and ran tests, everything worked.


Thanks,

Brian Wickman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message