aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jake Farrell" <jfarr...@apache.org>
Subject Re: Review Request 21055: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests
Date Sun, 04 May 2014 00:41:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21055/#review42099
-----------------------------------------------------------


Nice work Dan, overall just some minimal comments aimed more at the review group than the
actual patch iteself. Thanks for picking this up and finishing the work on it

- Jake Farrell


On May 4, 2014, 12:02 a.m., Dan Norris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21055/
> -----------------------------------------------------------
> 
> (Updated May 4, 2014, 12:02 a.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large
tests
> 
> I took this over from wickman at his request (old review: https://reviews.apache.org/r/19955/).
> 
> Changes:
> - Use mesos 0.18.0 instead of 0.17.0
> - Download mesos source from apache.org
> - Conditionally build mesos .egg
> - Fix a test in test_thermos_executor.py that was broken
> 
> 
> Diffs
> -----
> 
>   .mesosversion PRE-CREATION 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f 
>   build-support/jenkins/build_executor.sh PRE-CREATION 
>   build-support/jenkins/build_mesos.sh PRE-CREATION 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 0b143d0a2cbb25c1d35f79963478800a6b6713ec

> 
> Diff: https://reviews.apache.org/r/21055/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build_mesos.sh && ./pants src/test/python/apache/aurora/executor:executor-large
-vxs (what the new build_executor.sh script does)
> 
> 
> Thanks,
> 
> Dan Norris
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message