Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DB08110CE6 for ; Mon, 28 Apr 2014 22:58:42 +0000 (UTC) Received: (qmail 27869 invoked by uid 500); 28 Apr 2014 22:58:42 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 27829 invoked by uid 500); 28 Apr 2014 22:58:41 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 27821 invoked by uid 99); 28 Apr 2014 22:58:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Apr 2014 22:58:41 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 28 Apr 2014 22:58:40 +0000 Received: (qmail 27777 invoked by uid 99); 28 Apr 2014 22:58:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Apr 2014 22:58:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 609431D722B; Mon, 28 Apr 2014 22:58:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5359220356961945036==" MIME-Version: 1.0 Subject: Review Request 20808: Adding unhandled error logging into AsyncModule. From: "Maxim Khutornenko" To: "Bill Farner" Cc: "Aurora" , "Maxim Khutornenko" Date: Mon, 28 Apr 2014 22:58:11 -0000 Message-ID: <20140428225811.1869.7002@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/20808/ X-Sender: "Maxim Khutornenko" Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============5359220356961945036== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20808/ ----------------------------------------------------------- Review request for Aurora and Bill Farner. Bugs: AURORA-366 https://issues.apache.org/jira/browse/AURORA-366 Repository: aurora Description ------- Moved ScheduledThreadPoolExecutor creation into AsyncUtil to share across. Diffs ----- src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 00923723a60866145d481ea505b9a51d0e54832c src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 535acd21abda1473c1a364230bbd5b6b92e228bd src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 6aff091d9afefc73af666f980ef96acd726aec20 src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 0c6a2b8ea40c5459950037bc5683b5072f6731f5 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 6c723393000133452afd841cbaef4dad3c5806b5 src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java a1a0b428ba42d1abefed18bb40ca54c351154e11 Diff: https://reviews.apache.org/r/20808/diff/ Testing ------- Manual testing via gradle run (any ideas on how to unit test this properly without passing a logger as arg are welcome). Thanks, Maxim Khutornenko --===============5359220356961945036==--