Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7495BFA6E for ; Fri, 25 Apr 2014 19:42:25 +0000 (UTC) Received: (qmail 61059 invoked by uid 500); 25 Apr 2014 19:42:21 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 60997 invoked by uid 500); 25 Apr 2014 19:42:20 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 60843 invoked by uid 99); 25 Apr 2014 19:42:19 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Apr 2014 19:42:19 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 25 Apr 2014 19:42:18 +0000 Received: (qmail 60462 invoked by uid 99); 25 Apr 2014 19:41:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Apr 2014 19:41:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CCA3D1D712C; Fri, 25 Apr 2014 19:41:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7461117851169867231==" MIME-Version: 1.0 Subject: Review Request 20726: Removing client HTTP health checks. From: "Maxim Khutornenko" To: "Brian Wickman" , "Mark Chu-Carroll" Cc: "Aurora" , "Maxim Khutornenko" Date: Fri, 25 Apr 2014 19:41:47 -0000 Message-ID: <20140425194147.5212.278@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/20726/ X-Sender: "Maxim Khutornenko" Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7461117851169867231== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20726/ ----------------------------------------------------------- Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-361 https://issues.apache.org/jira/browse/AURORA-361 Repository: aurora Description ------- Dropping client http health checks in favor of status checks only. Diffs ----- src/main/python/apache/aurora/client/api/health_check.py e3bbf71a37c3137d580378ac185eaf65f4b056af src/main/python/apache/aurora/client/api/instance_watcher.py 530868348142c73708fa7f0d7296a3fb5b6ebb5d src/test/python/apache/aurora/client/api/test_health_check.py f59fe42cc4808aeece34f55978ca34e62404ac58 src/test/python/apache/aurora/client/cli/test_restart.py 43412c44edba19e8c7d753118d7ad0be78a4fd39 src/test/python/apache/aurora/client/cli/test_update.py e3e433262f354ed0573273bd0c28746c3cef902b src/test/python/apache/aurora/client/commands/test_restart.py 526c501869b7ae22550e5d84613ca38f8071b9b7 src/test/python/apache/aurora/client/commands/test_update.py f90783779805313f529487509f7d457ba8ee138c Diff: https://reviews.apache.org/r/20726/diff/ Testing ------- ./pants src/test/python:all ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko --===============7461117851169867231==--