Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 255CFF833 for ; Fri, 25 Apr 2014 18:45:29 +0000 (UTC) Received: (qmail 42824 invoked by uid 500); 25 Apr 2014 18:45:21 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 42756 invoked by uid 500); 25 Apr 2014 18:45:20 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 42686 invoked by uid 99); 25 Apr 2014 18:45:18 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Apr 2014 18:45:18 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 25 Apr 2014 18:45:16 +0000 Received: (qmail 41611 invoked by uid 99); 25 Apr 2014 18:44:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Apr 2014 18:44:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3995A1D712A; Fri, 25 Apr 2014 18:44:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4540989085688532507==" MIME-Version: 1.0 Subject: Re: Review Request 20723: Add batch options to kill and killall. From: "David McLaughlin" To: "Suman Karumuri" , "David McLaughlin" Cc: "Aurora" , "Mark Chu-Carroll" Date: Fri, 25 Apr 2014 18:44:45 -0000 Message-ID: <20140425184445.25434.29967@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "David McLaughlin" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/20723/ X-Sender: "David McLaughlin" References: <20140425182309.5212.39519@reviews.apache.org> In-Reply-To: <20140425182309.5212.39519@reviews.apache.org> Reply-To: "David McLaughlin" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4540989085688532507== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20723/#review41505 ----------------------------------------------------------- src/main/python/apache/aurora/client/options.py Shouldn't this be batch_size for consistency with the other commands? - David McLaughlin On April 25, 2014, 6:23 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20723/ > ----------------------------------------------------------- > > (Updated April 25, 2014, 6:23 p.m.) > > > Review request for Aurora, David McLaughlin and Suman Karumuri. > > > Bugs: aurora-356 > https://issues.apache.org/jira/browse/aurora-356 > > > Repository: aurora > > > Description > ------- > > Add batch options to kill and killall. (This brings the kill commands in client v1 into parity with client v2. > At the moment, in order to avoid disrupting current users, v1 still defaults to non-batched operation.) > > > Diffs > ----- > > src/main/python/apache/aurora/client/commands/core.py 67c061eace86b7a28d2c3ae03e23c7d77fc7957f > src/main/python/apache/aurora/client/options.py 0d85c360dc4c62ab0baf58315a68a32c304fcffc > src/test/python/apache/aurora/client/commands/test_kill.py 825f5f13da1c8bee843581a34f3357c0fa2dbb00 > > Diff: https://reviews.apache.org/r/20723/diff/ > > > Testing > ------- > > [sun-wukong incubator-aurora (batch_v1)]$ ./pants src/test/python/apache/aurora/client/commands:all > Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/commands/BUILD:all)]) > ============================= test session starts ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 13 items > > src/test/python/apache/aurora/client/commands/test_admin_sla.py ............. > > ========================== 13 passed in 0.57 seconds =========================== > ============================= test session starts ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 28 items > > src/test/python/apache/aurora/client/commands/test_cancel_update.py .. > src/test/python/apache/aurora/client/commands/test_create.py ...... > src/test/python/apache/aurora/client/commands/test_diff.py ... > src/test/python/apache/aurora/client/commands/test_kill.py ...... > src/test/python/apache/aurora/client/commands/test_listjobs.py .. > src/test/python/apache/aurora/client/commands/test_restart.py ... > src/test/python/apache/aurora/client/commands/test_status.py ... > src/test/python/apache/aurora/client/commands/test_update.py ... > > ========================== 28 passed in 1.47 seconds =========================== > ============================= test session starts ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 3 items > > src/test/python/apache/aurora/client/commands/test_hooks.py ... > > =========================== 3 passed in 1.21 seconds =========================== > ============================= test session starts ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/commands/test_maintenance.py .... > > =========================== 4 passed in 0.48 seconds =========================== > ============================= test session starts ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 1 items > > src/test/python/apache/aurora/client/commands/test_run.py . > > =========================== 1 passed in 0.58 seconds =========================== > ============================= test session starts ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 1 items > > src/test/python/apache/aurora/client/commands/test_ssh.py . > > =========================== 1 passed in 0.47 seconds =========================== > src.test.python.apache.aurora.client.commands.admin ..... SUCCESS > src.test.python.apache.aurora.client.commands.core ..... SUCCESS > src.test.python.apache.aurora.client.commands.hooks ..... SUCCESS > src.test.python.apache.aurora.client.commands.maintenance ..... SUCCESS > src.test.python.apache.aurora.client.commands.run ..... SUCCESS > src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS > [sun-wukong incubator-aurora (batch_v1)]$ > > > Thanks, > > Mark Chu-Carroll > > --===============4540989085688532507==--