Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D50A911731 for ; Thu, 24 Apr 2014 06:42:50 +0000 (UTC) Received: (qmail 49994 invoked by uid 500); 24 Apr 2014 06:42:50 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 49960 invoked by uid 500); 24 Apr 2014 06:42:49 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 49952 invoked by uid 99); 24 Apr 2014 06:42:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Apr 2014 06:42:48 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 24 Apr 2014 06:42:47 +0000 Received: (qmail 49859 invoked by uid 99); 24 Apr 2014 06:42:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Apr 2014 06:42:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AC9891D704D; Thu, 24 Apr 2014 06:42:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1665581064204322785==" MIME-Version: 1.0 Subject: Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code. From: "Suman Karumuri" To: "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" , "Suman Karumuri" Date: Thu, 24 Apr 2014 06:42:21 -0000 Message-ID: <20140424064221.2045.3593@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Suman Karumuri" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/20648/ X-Sender: "Suman Karumuri" References: <20140424042246.28377.11088@reviews.apache.org> In-Reply-To: <20140424042246.28377.11088@reviews.apache.org> Reply-To: "Suman Karumuri" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============1665581064204322785== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/#review41273 ----------------------------------------------------------- Ship it! +1 - Suman Karumuri On April 24, 2014, 4:22 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20648/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 4:22 a.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-340 > https://issues.apache.org/jira/browse/AURORA-340 > > > Repository: aurora > > > Description > ------- > > Remove IsolatedSchedulerModule and surrounding code. > > > Diffs > ----- > > build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 > src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 9a78fb9be8578f8cea2e51c0ebf385aafdc8b2a9 > src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 1bfd4b69584122f62616ce93098a56fe3cf195d8 > src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 9186aebef2babc4a76fe05eb3b412be26d7de3c6 > src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java d8f19e6c1eac1567b3194c5d4ebeb0d5b95073e6 > src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java cc31187607e89a9daebe071a8a180d56d873e4c5 > > Diff: https://reviews.apache.org/r/20648/diff/ > > > Testing > ------- > > ./gradlew build > sh examples/vagrant/test_tutorial.sh > > > Thanks, > > Bill Farner > > --===============1665581064204322785==--