Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 87E9C11879 for ; Tue, 22 Apr 2014 21:16:04 +0000 (UTC) Received: (qmail 3913 invoked by uid 500); 22 Apr 2014 21:16:00 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 3829 invoked by uid 500); 22 Apr 2014 21:15:59 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 3780 invoked by uid 99); 22 Apr 2014 21:15:58 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Apr 2014 21:15:57 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 22 Apr 2014 21:15:56 +0000 Received: (qmail 3438 invoked by uid 99); 22 Apr 2014 21:15:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Apr 2014 21:15:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4B2681D6F22; Tue, 22 Apr 2014 21:15:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3525871305406838358==" MIME-Version: 1.0 Subject: Re: Review Request 20573: BugFix: Incorrect task count count in Role and Role/env page. From: "Bill Farner" To: "Bill Farner" Cc: "Aurora" , "Suman Karumuri" Date: Tue, 22 Apr 2014 21:15:26 -0000 Message-ID: <20140422211526.25480.67685@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/20573/ X-Sender: "Bill Farner" References: <20140422204356.25480.58660@reviews.apache.org> In-Reply-To: <20140422204356.25480.58660@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3525871305406838358== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20573/#review41066 ----------------------------------------------------------- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java This method signature is difficult to read. You ~always need to go to the method signature to figure out what the flag is for. How about accepting a Query.Builder instead? Then you have: getTasks(Query.roleScoped(ownerRole)) getTasks(Query.roleScoped(ownerRole).active()) - Bill Farner On April 22, 2014, 8:43 p.m., Suman Karumuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20573/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 8:43 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-338 > https://issues.apache.org/jira/browse/AURORA-338 > > > Repository: aurora > > > Description > ------- > > Currently, the getTasks query was only fetching tasks in active status. Updated the code to fetching all tasks for getJobSummary. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 84151a5308c12b3bee7cf5fd662776e574e8fadf > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java f530c530548444c57d9aeb5ed100a5fda5bd2953 > > Diff: https://reviews.apache.org/r/20573/diff/ > > > Testing > ------- > > Tested on laptop. > > > Thanks, > > Suman Karumuri > > --===============3525871305406838358==--