Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EEAB5114BF for ; Mon, 21 Apr 2014 21:59:00 +0000 (UTC) Received: (qmail 59952 invoked by uid 500); 21 Apr 2014 21:59:00 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 59912 invoked by uid 500); 21 Apr 2014 21:59:00 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 59901 invoked by uid 99); 21 Apr 2014 21:58:59 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Apr 2014 21:58:59 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 21 Apr 2014 21:58:57 +0000 Received: (qmail 59810 invoked by uid 99); 21 Apr 2014 21:58:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Apr 2014 21:58:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5A3511D5FF2; Mon, 21 Apr 2014 21:58:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5704124077937496598==" MIME-Version: 1.0 Subject: Re: Review Request 20285: Improve documentation and testing for host maintenance API From: "Bill Farner" To: "David Robinson" , "Bill Farner" , "Tobias Weingartner" , "Kevin Sweeney" Cc: "Joe Smith" , "Aurora" Date: Mon, 21 Apr 2014 21:58:27 -0000 Message-ID: <20140421215827.19702.86067@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/20285/ X-Sender: "Bill Farner" References: <20140412234515.10503.60458@reviews.apache.org> In-Reply-To: <20140412234515.10503.60458@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============5704124077937496598== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20285/#review40964 ----------------------------------------------------------- Ship it! src/main/python/apache/aurora/admin/host_maintenance.py s/divide/break into groups/ src/main/python/apache/aurora/admin/host_maintenance.py s/strings/host names, which must match the host names that slaves are registered with/ src/main/python/apache/aurora/admin/host_maintenance.py Doc makes it sound like this is a callable being passed. Either make it a callable, or note that it's a key into GROUPING_FUNCTIONS. src/main/python/apache/aurora/admin/host_maintenance.py "Drains tasks from the specified hosts. This will move active tasks on these hosts to the DRAINING state, causing them to be rescheduled elsewhere." src/main/python/apache/aurora/admin/host_maintenance.py "Source for the current time" - Bill Farner On April 12, 2014, 11:45 p.m., Joe Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20285/ > ----------------------------------------------------------- > > (Updated April 12, 2014, 11:45 p.m.) > > > Review request for Aurora, David Robinson, Kevin Sweeney, Tobias Weingartner, and Bill Farner. > > > Bugs: AURORA-318 > https://issues.apache.org/jira/browse/AURORA-318 > > > Repository: aurora > > > Description > ------- > > Add way more docstrings as well as unit tests for the HostMaintenance api. > > > Diffs > ----- > > src/main/python/apache/aurora/admin/host_maintenance.py 6a21ddeb4203a07a04360f68c4a338fe3da52c70 > src/test/python/apache/aurora/admin/BUILD 17aac54d636024a8e131eb2e4d996c2e15401de1 > src/test/python/apache/aurora/admin/test_host_maintenance.py 95497aea3d3f769b2460adbfe7a7b72d775ced6f > > Diff: https://reviews.apache.org/r/20285/diff/ > > > Testing > ------- > > 16:39:58 incubator-aurora $ ./pants ./src/test/python/apache/aurora/admin:all > Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/admin/BUILD:all)]) > ============================================================================================================ test session starts ============================================================================================================= > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 9 items > > src/test/python/apache/aurora/admin/test_host_maintenance.py ......... > > ========================================================================================================== 9 passed in 0.67 seconds ========================================================================================================== > src.test.python.apache.aurora.admin.host_maintenance ..... SUCCESS > > > Thanks, > > Joe Smith > > --===============5704124077937496598==--