Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6B9C5119AC for ; Mon, 21 Apr 2014 16:36:00 +0000 (UTC) Received: (qmail 30623 invoked by uid 500); 21 Apr 2014 16:35:59 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 30581 invoked by uid 500); 21 Apr 2014 16:35:59 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 30572 invoked by uid 99); 21 Apr 2014 16:35:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Apr 2014 16:35:59 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 21 Apr 2014 16:35:57 +0000 Received: (qmail 30290 invoked by uid 99); 21 Apr 2014 16:35:37 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Apr 2014 16:35:37 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0102C1C6D08; Mon, 21 Apr 2014 16:35:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6384477485120409009==" MIME-Version: 1.0 Subject: Re: Review Request 20521: Extend the client configuration plugin architecture. From: "Mark Chu-Carroll" To: "David Robinson" , "Maxim Khutornenko" Cc: "Aurora" , "Mark Chu-Carroll" Date: Mon, 21 Apr 2014 16:35:31 -0000 Message-ID: <20140421163531.19702.20065@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mark Chu-Carroll" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/20521/ X-Sender: "Mark Chu-Carroll" References: <20140421133310.19702.71768@reviews.apache.org> In-Reply-To: <20140421133310.19702.71768@reviews.apache.org> Reply-To: "Mark Chu-Carroll" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6384477485120409009== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/#review40885 ----------------------------------------------------------- src/main/python/apache/aurora/client/cli/__init__.py Very good suggestion! src/main/python/apache/aurora/client/cli/__init__.py This has nothing to do with hooks: this is how error codes get returned when a verb implementation throws a Context.CommandError. The exception carries the exit code. - Mark Chu-Carroll On April 21, 2014, 9:33 a.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20521/ > ----------------------------------------------------------- > > (Updated April 21, 2014, 9:33 a.m.) > > > Review request for Aurora, David Robinson and Maxim Khutornenko. > > > Bugs: aurora-332 > https://issues.apache.org/jira/browse/aurora-332 > > > Repository: aurora > > > Description > ------- > > Extend the client configuration plugin architecture. > > Plugins can now run code at three key points: > - Before arguments are processed and execution is dispatched to a command. > - After argument processing and dispatch, but before execution. > - After execution. > > This allows plugins to perform initialization required for argument processing, > and for post-execution cleanups and synchronizations. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py f1165a05c7c66d7a06f4733eb65ae4a7de6fad76 > src/test/python/apache/aurora/client/cli/test_plugins.py 7cacb02ffda05fdf87a9334ed1de2092efb39f8b > > Diff: https://reviews.apache.org/r/20521/diff/ > > > Testing > ------- > > [sun-wukong incubator-aurora (plugin_with_cleanup)]$ ./pants src/test/python/apache/aurora/client/cli:all > Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > ============================================== test session starts =============================================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py .... > > ============================================ 4 passed in 0.02 seconds ============================================ > ============================================== test session starts =============================================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_help.py ..... > > ============================================ 5 passed in 0.76 seconds ============================================ > ============================================== test session starts =============================================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 36 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py .... > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py ......... > src/test/python/apache/aurora/client/cli/test_open.py ..... > src/test/python/apache/aurora/client/cli/test_restart.py ... > src/test/python/apache/aurora/client/cli/test_status.py ....... > src/test/python/apache/aurora/client/cli/test_update.py ... > > =========================================== 36 passed in 2.02 seconds ============================================ > ============================================== test session starts =============================================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 1 items > > src/test/python/apache/aurora/client/cli/test_logging.py . > > ============================================ 1 passed in 0.68 seconds ============================================ > ============================================== test session starts =============================================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_plugins.py .. > > ============================================ 2 passed in 0.63 seconds ============================================ > ============================================== test session starts =============================================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_quota.py .... > > ============================================ 4 passed in 0.61 seconds ============================================ > ============================================== test session starts =============================================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_sla.py ..... > > ============================================ 5 passed in 0.59 seconds ============================================ > ============================================== test session starts =============================================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_task_run.py .. > > ============================================ 2 passed in 0.59 seconds ============================================ > src.test.python.apache.aurora.client.cli.bridge ..... SUCCESS > src.test.python.apache.aurora.client.cli.help ..... SUCCESS > src.test.python.apache.aurora.client.cli.job ..... SUCCESS > src.test.python.apache.aurora.client.cli.logging ..... SUCCESS > src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS > src.test.python.apache.aurora.client.cli.quota ..... SUCCESS > src.test.python.apache.aurora.client.cli.sla ..... SUCCESS > src.test.python.apache.aurora.client.cli.task ..... SUCCESS > [sun-wukong incubator-aurora (plugin_with_cleanup)]$ > > > Thanks, > > Mark Chu-Carroll > > --===============6384477485120409009==--