Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ED19A10DB7 for ; Wed, 2 Apr 2014 00:17:54 +0000 (UTC) Received: (qmail 25382 invoked by uid 500); 2 Apr 2014 00:17:54 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 25342 invoked by uid 500); 2 Apr 2014 00:17:53 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 25334 invoked by uid 99); 2 Apr 2014 00:17:53 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Apr 2014 00:17:53 +0000 X-ASF-Spam-Status: No, hits=-1998.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 02 Apr 2014 00:17:52 +0000 Received: (qmail 25278 invoked by uid 99); 2 Apr 2014 00:17:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Apr 2014 00:17:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 54F0A1D5B40; Wed, 2 Apr 2014 00:17:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6519946058583575556==" MIME-Version: 1.0 Subject: Re: Review Request 19888: Prepare to store UNKNOWN state. From: "Maxim Khutornenko" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Maxim Khutornenko" Date: Wed, 02 Apr 2014 00:17:27 -0000 Message-ID: <20140402001727.16750.55273@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/19888/ X-Sender: "Maxim Khutornenko" References: <20140402001120.16750.16944@reviews.apache.org> In-Reply-To: <20140402001120.16750.16944@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6519946058583575556== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On April 2, 2014, 12:11 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java, line 120 > > > > > > use List#remove(int) here, it returns the removed element. I don't want to remove it. I am getting prev, extracting state from it and dropping last. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19888/#review39220 ----------------------------------------------------------- On April 2, 2014, 12:05 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19888/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 12:05 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-261 > https://issues.apache.org/jira/browse/AURORA-261 > > > Repository: aurora > > > Description > ------- > > Before we start storing UNKNOWN (SANDBOX_DELETED) state need to prepare for a graceful rollback of that change. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 6622216c285eb1c25c7648769a7d7676e8b73bcc > src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/19888/diff/ > > > Testing > ------- > > gradle clean build > > > Thanks, > > Maxim Khutornenko > > --===============6519946058583575556==--