aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Review Request 20916: Fixing flaky unit test.
Date Wed, 30 Apr 2014 20:42:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20916/
-----------------------------------------------------------

Review request for Aurora.


Repository: aurora


Description
-------

The future.get() in this test is prone to race condition with the executor thread (i.e. it
may result in throwing on a main rather than child thread). Converting to a more robust approach.


Diffs
-----

  src/test/java/org/apache/aurora/scheduler/base/AsyncUtilTest.java 2e5875f00894fc9b33657912b3a0faf4012f88b7


Diff: https://reviews.apache.org/r/20916/diff/


Testing
-------

gradle clean build


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message