aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 20808: Adding unhandled error logging into AsyncModule.
Date Tue, 29 Apr 2014 20:04:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20808/#review41768
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java
<https://reviews.apache.org/r/20808/#comment75350>

    Nice!  To really polish this off, you could accept a Logger to prove the bug fix in a
unit test.



src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java
<https://reviews.apache.org/r/20808/#comment75351>

    Can you toss in a comment that this sequence is borrowed from advice on the ThreadPoolExecutor
javadoc?
    
    http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ThreadPoolExecutor.html#afterExecute(java.lang.Runnable,
java.lang.Throwable)


- Bill Farner


On April 28, 2014, 10:58 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20808/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 10:58 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-366
>     https://issues.apache.org/jira/browse/AURORA-366
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Moved ScheduledThreadPoolExecutor creation into AsyncUtil to share across. 
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 00923723a60866145d481ea505b9a51d0e54832c

>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 535acd21abda1473c1a364230bbd5b6b92e228bd

>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 6aff091d9afefc73af666f980ef96acd726aec20

>   src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 0c6a2b8ea40c5459950037bc5683b5072f6731f5

>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 6c723393000133452afd841cbaef4dad3c5806b5

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java a1a0b428ba42d1abefed18bb40ca54c351154e11

> 
> Diff: https://reviews.apache.org/r/20808/diff/
> 
> 
> Testing
> -------
> 
> Manual testing via gradle run (any ideas on how to unit test this properly without passing
a logger as arg are welcome).
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message