aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <ma...@apache.org>
Subject Re: Review Request 20707: Fix a plugins glitch.
Date Fri, 25 Apr 2014 23:29:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20707/#review41541
-----------------------------------------------------------

Ship it!


Ship It!

- Suman Karumuri


On April 25, 2014, 6:33 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20707/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 6:33 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-362
>     https://issues.apache.org/jira/browse/aurora-362
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix a plugins glitch.
> 
> The before_dispatch method in configuration plugins is allowed to alter
> command line arguments, to add or remove arguments needed to support
> specific environments. The default implementation of plugins doesn't
> provide any return value for the plugin methods. For before_dispatch,
> this meant that the default plugin method effectively removed all command
> line parameters!
> 
> This change just turns the default before_dispatch plugin method into an
> effective no-op. If the user doesn't provide a before_dispatch method,
> the default implementation will leave the arguments correctly unchanged.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 5a10328e49f0128965aed73b9c167324dfcfde0f

>   src/test/python/apache/aurora/client/cli/test_plugins.py 64bde45b203d9b5db0c032bd964a38bd563283de

> 
> Diff: https://reviews.apache.org/r/20707/diff/
> 
> 
> Testing
> -------
> 
> [sun-wukong incubator-aurora (fix_plugins)]$ ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/test_binding_helper.py ..
> 
> =========================== 2 passed in 0.46 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/test_config.py ......
> 
> =========================== 6 passed in 0.54 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
> 
> =========================== 6 passed in 0.48 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
> 
> =========================== 1 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_restarter.py ......
> 
> =========================== 6 passed in 0.41 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
> 
> src/test/python/apache/aurora/client/api/test_scheduler_client.py ...............................................
> 
> ===================== 47 passed, 1 skipped in 4.48 seconds =====================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
> 
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
> 
> ========================== 20 passed in 0.32 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
> 
> src/test/python/apache/aurora/client/api/test_updater.py ...........................
> 
> ========================== 27 passed in 0.73 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
> 
> =========================== 6 passed in 0.15 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 31 items
> 
> src/test/python/apache/aurora/client/api/test_sla.py ...............................
> 
> ========================== 31 passed in 0.27 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
> 
> =========================== 4 passed in 0.02 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .....
> 
> =========================== 5 passed in 0.53 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .........
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> ========================== 36 passed in 1.99 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> =========================== 1 passed in 0.55 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_plugins.py ..
> 
> =========================== 2 passed in 0.59 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_quota.py ....
> 
> =========================== 4 passed in 0.55 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> 
> =========================== 5 passed in 0.59 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
> 
> =========================== 2 passed in 0.58 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 13 items
> 
> src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
> 
> ========================== 13 passed in 0.52 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 26 items
> 
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ....
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ...
> src/test/python/apache/aurora/client/commands/test_update.py ...
> 
> ========================== 26 passed in 1.42 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 3 items
> 
> src/test/python/apache/aurora/client/commands/test_hooks.py ...
> 
> =========================== 3 passed in 1.08 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/commands/test_maintenance.py ....
> 
> =========================== 4 passed in 0.47 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/commands/test_run.py .
> 
> =========================== 1 passed in 0.49 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/commands/test_ssh.py .
> 
> =========================== 1 passed in 0.46 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 12 items
> 
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
> 
> ========================== 12 passed in 0.45 seconds ===========================
> ============================= test session starts ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 4 items
> 
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
> 
> =========================== 4 passed in 0.44 seconds ===========================
> src.test.python.apache.aurora.client.api.disambiguator                          .....
  SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher                       .....
  SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor                            .....
  SUCCESS
> src.test.python.apache.aurora.client.api.quota_check                            .....
  SUCCESS
> src.test.python.apache.aurora.client.api.restarter                              .....
  SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client                       .....
  SUCCESS
> src.test.python.apache.aurora.client.api.sla                                    .....
  SUCCESS
> src.test.python.apache.aurora.client.api.updater                                .....
  SUCCESS
> src.test.python.apache.aurora.client.binding_helper                             .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.bridge                                 .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.help                                   .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.job                                    .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.logging                                .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.plugins                                .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.quota                                  .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.sla                                    .....
  SUCCESS
> src.test.python.apache.aurora.client.cli.task                                   .....
  SUCCESS
> src.test.python.apache.aurora.client.commands.admin                             .....
  SUCCESS
> src.test.python.apache.aurora.client.commands.core                              .....
  SUCCESS
> src.test.python.apache.aurora.client.commands.hooks                             .....
  SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance                       .....
  SUCCESS
> src.test.python.apache.aurora.client.commands.run                               .....
  SUCCESS
> src.test.python.apache.aurora.client.commands.ssh                               .....
  SUCCESS
> src.test.python.apache.aurora.client.config                                     .....
  SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api                           .....
  SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api                       .....
  SUCCESS
> [sun-wukong incubator-aurora (fix_plugins)]$
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message