aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 20650: Exclude reports directory from idea project.
Date Thu, 24 Apr 2014 17:32:53 GMT


> On April 24, 2014, 6:36 a.m., Suman Karumuri wrote:
> > build.gradle, line 338
> > <https://reviews.apache.org/r/20650/diff/1/?file=566717#file566717line338>
> >
> >     Can we add dist/ to this list?
> 
> Jake Farrell wrote:
>     +1 with dist added

You cannot exclude dist/, since our generated code lands beneath dist (see comment immediately
above this line).  We could put generated source elsewhere, but i don't want to do that without
more careful thought (Kevin had the idea to use a subproject for code generation, which might
be a better route).


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
-----------------------------------------------------------


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much longer
than necesary, and causes bogus results when searching for usages of symbols.  This fixes
(the majority, at least) both issues.
> 
> 
> Diffs
> -----
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> -------
> 
> IDEA no longer goes into as much of an indexing frenzy after running ./gradlew build,
and searching for symbols does not turn up javadoc HTML and test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message