aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js
Date Wed, 23 Apr 2014 15:14:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20146/#review41146
-----------------------------------------------------------

Ship it!



src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js
<https://reviews.apache.org/r/20146/#comment74556>

    Missing "," for the new records.


- Maxim Khutornenko


On April 23, 2014, 3:02 p.m., Dan Norris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20146/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 3:02 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-265
>     https://issues.apache.org/jira/browse/AURORA-265
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-265: Add missing tooltips for task states in dictionary.js
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 3db34ecf9a977fe4c84d1d00990d90248b40316e

> 
> Diff: https://reviews.apache.org/r/20146/diff/
> 
> 
> Testing
> -------
> 
> Visually inspected the scheduler w/ a sample job to verify that nothing was messed up.
I'm not sure how to force a task with the Vagrant file into DRAINING or THROTTLED states.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message