aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jake Farrell" <jfarr...@apache.org>
Subject Re: Review Request 20571: Replace sed command with linux and OSX-friendly perl expression.
Date Tue, 22 Apr 2014 19:58:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20571/#review41054
-----------------------------------------------------------

Ship it!


Whats the bug associated with this? other than that +1

- Jake Farrell


On April 22, 2014, 7:55 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20571/
> -----------------------------------------------------------
> 
> (Updated April 22, 2014, 7:55 p.m.)
> 
> 
> Review request for Aurora and Jake Farrell.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Replace sed command with linux and OSX-friendly perl expression.
> 
> Some context discussion here: http://stackoverflow.com/questions/2320564/variations-of-sed-between-osx-and-gnu-linux
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/test_tutorial.sh 1b745b817feffc955fd6fce34eeeb520663302fb 
> 
> Diff: https://reviews.apache.org/r/20571/diff/
> 
> 
> Testing
> -------
> 
> I can now successfully run this script on OS X 10.9 and Ubuntu 13.10.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message