aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suman Karumuri" <ma...@apache.org>
Subject Re: Review Request 20512: Role and Job pages using new Angular UI.
Date Mon, 21 Apr 2014 21:41:09 GMT


> On April 21, 2014, 8:14 p.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 416
> > <https://reviews.apache.org/r/20512/diff/1/?file=562936#file562936line416>
> >
> >     Looks like this is set as of the last event, which should be the previous in
case of SANDBOX_DELETED. You can check task.statusTimestamp in my original RB.

Nice catch! Fixed.


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20512/#review40932
-----------------------------------------------------------


On April 21, 2014, 9:40 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20512/
> -----------------------------------------------------------
> 
> (Updated April 21, 2014, 9:40 p.m.)
> 
> 
> Review request for Aurora and Suman Karumuri.
> 
> 
> Bugs: AURORA-281
>     https://issues.apache.org/jira/browse/AURORA-281
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Full code diff for role and env page.
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/bootstrap-glyphicons-master/README.md PRE-CREATION 
>   3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.css PRE-CREATION

>   3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.min.css PRE-CREATION

>   3rdparty/javascript/bootstrap-glyphicons-master/glyphicons.png PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION

>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION

>   3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/ar-ma.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/ar.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/bg.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/br.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/bs.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/ca.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/cs.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/cv.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/cy.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/da.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/de.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/el.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/en-au.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/en-ca.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/en-gb.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/eo.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/es.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/et.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/eu.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/fa.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/fi.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/fo.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/fr-ca.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/fr.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/gl.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/he.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/hi.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/hr.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/hu.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/hy-am.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/id.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/is.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/it.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/ja.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/ka.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/ko.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/lb.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/lt.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/lv.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/mk.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/ml.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/mr.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/ms-my.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/nb.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/ne.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/nl.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/nn.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/pl.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/pt-br.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/pt.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/ro.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/rs.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/ru.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/sk.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/sl.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/sq.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/sv.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/ta.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/th.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/tl-ph.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/tr.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/tzm-la.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/tzm.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/uk.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/uz.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/vn.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/zh-cn.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/lang/zh-tw.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/min/langs.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/min/langs.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/min/moment-with-langs.js PRE-CREATION

>   3rdparty/javascript/bower_components/momentjs/min/moment-with-langs.min.js PRE-CREATION

>   3rdparty/javascript/bower_components/momentjs/min/moment.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/moment.js PRE-CREATION 
>   3rdparty/javascript/bower_components/momentjs/readme.md PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
>   build.gradle 3c0c63710dfb177dc2df1d504cbc00d75bce67c6 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java eeafc784e915137cacd5f64df1252ccbaf6c0f6c

>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java ec56c649116c03ef148bac916bd6691a94685bc3

>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba

>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java f0469c157fee79c4fd2b842db7a4a37fd3d7e83e

>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342

>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c

>   src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java b35aad8db006133ba70692e43db1f083d4950914

>   src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java b931baa3f610095d4c46582da5d5c1e06c8b0d8e

>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/css/jquery.dataTables.css
ee6da23c3948a87b0d4df73e82e5c4e2ab2bc803 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/back_disabled.png
881de7976ff98955e2a5487dca66e618a0655f3d 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/back_enabled.png
c608682b04a6d9b8002602450c8ef7e80ebba099 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/back_enabled_hover.png
d300f1064b3beac1d7d5274e294494d3143e53a2 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/forward_disabled.png
6a6ded7de821619aedc71d1738c0b73463a4452e 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/forward_enabled.png
a4e6b5384b8454ee7f44a8f7c75b0321b7eeb9b1 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/forward_enabled_hover.png
fc46c5ebf0524b72a509fe2d7c1bc74995cb8a9d 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/sort_asc.png
a88d7975fe9017e4e5f2289a94bd1ed66a5f59dc 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/sort_asc_disabled.png
4e144cf0b1f786a9248a2998311e8109998d8a2d 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/sort_both.png
18670406bc01ab2721781822dd6478917745ff54 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/sort_desc.png
def071ed5afd264a036f6d9e75856366fd6ad153 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/sort_desc_disabled.png
7824973cc60fc1841b16f2cb39323cefcdc3f942 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/js/dataTables.bootstrap.js
420e507086f7a2af08f68787f67208546745260d 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/js/dataTables.htmlNumberType.js
885ad347f3076dcf75558ef44806dc25a8171884 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/js/dataTables.localstorage.js
3c0b39aefbd5a82adee49f2ac7539b6974576b2f 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/js/jquery.dataTables.min.js
02694a4a56eb247baa2398d971927dfbd1ac3e60 
>   src/main/resources/org/apache/aurora/scheduler/http/assets/dictionary.js 92045c41706ee9315f3522c3b5bbff7f6e7d2c64

>   src/main/resources/org/apache/aurora/scheduler/http/assets/util.js 5dd0d17849c7116d70925275b9c6c0715b441f14

>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzjob.st aee1d569d5e75c759552c6a5ebc64fa7c9e8aea0

>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8

>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION

>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css ade850ce624964693e9bd55946464983c4b9f8c2

>   src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce

>   src/main/resources/org/apache/aurora/scheduler/http/ui/job.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c

>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97

>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5

>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8681bbe840b6285b15dd6766016258c2c8115632

>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION

>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383

>   src/main/resources/org/apache/aurora/scheduler/http/ui/schedulingDetail.html PRE-CREATION

>   src/main/resources/org/apache/aurora/scheduler/http/ui/taskLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/taskSandbox.html PRE-CREATION

>   src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html PRE-CREATION

>   src/main/thrift/org/apache/aurora/gen/api.thrift c37928f3c53174b5a568e782e0da568544bd8c34

>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java db63e7988008abec75f840bb7b6710c3d155d47b

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
fae2de11235dd059718e1023fdcfb0e8fc4deadd 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java
dd991fb90889c3f221e537a78283eb4a31e5f0dd 
> 
> Diff: https://reviews.apache.org/r/20512/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message