aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 20425: Shutdown cron asynchronously
Date Wed, 16 Apr 2014 21:19:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20425/#review40602
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java
<https://reviews.apache.org/r/20425/#comment73628>

    Borrowing from your reply to Maxim's comment - perhaps include a TODO to re-assess whether
we should be invoking shutdown of the cron system at all.  If it's using daemon threads (which
is what we'd want), i also don't see much point.


- Bill Farner


On April 16, 2014, 7:52 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20425/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 7:52 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-325
>     https://issues.apache.org/jira/browse/AURORA-325
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Shutdown cron asynchronously
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java fa39e2b901bdc764d802a05d26ee73d77ef7604d

> 
> Diff: https://reviews.apache.org/r/20425/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message