aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 20246: AURORA-299: use system thrift if available
Date Tue, 15 Apr 2014 18:06:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20246/#review40422
-----------------------------------------------------------


Thanks for pushing on this.  I went down this road and backed out since i didn't think of
catching the exception.


build.gradle
<https://reviews.apache.org/r/20246/#comment73413>

    please remove trailing whitespace here and elsewhere



build.gradle
<https://reviews.apache.org/r/20246/#comment73416>

    When i ventured down this path, i discovered a more concise way to run a command and capture
output.  Try this out:
    
      def output = "thrift --version".execute().text.trim()
      if (output == "Thrift version ${thriftVersion}") {
        ...
      }



build.gradle
<https://reviews.apache.org/r/20246/#comment73412>

    Please add a comment here detailing the error you expect.  It would also be nice to be
more specific than Exception.  With the suggestion above, at least, i think you want IOException.


- Bill Farner


On April 11, 2014, 1:29 a.m., Jake Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20246/
> -----------------------------------------------------------
> 
> (Updated April 11, 2014, 1:29 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-299
>     https://issues.apache.org/jira/browse/AURORA-299
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-299: use system thrift if available
> 
> Updates gradle bootstrapThrift to use a system installed Thrift if available
> and if it is the same version we are currently using.
> 
> 
> Diffs
> -----
> 
>   build.gradle cdcc0158079bc91b5c10fad4e7c80d2f98da227f 
> 
> Diff: https://reviews.apache.org/r/20246/diff/
> 
> 
> Testing
> -------
> 
> ran build with and without Thrift installed
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message